Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow edit of oEmbed URL on FileSet #3177

Open
wickr opened this issue Oct 16, 2024 · 2 comments · May be fixed by #3192
Open

Allow edit of oEmbed URL on FileSet #3177

wickr opened this issue Oct 16, 2024 · 2 comments · May be fixed by #3192
Assignees
Labels
Features Issues related to building and enhancing features

Comments

@wickr
Copy link
Member

wickr commented Oct 16, 2024

Descriptive summary

After creating a work with an oEmbed URL added, a FileSet is made with the oEmbed URL. However, there's no way to edit the oEmbed URL, as there's no exposed field on FileSet edit view. Example: https://staging.oregondigital.org/concern/file_sets/np193921h/edit?locale=en#descriptions_display

Expected behavior

A FileSet with an oEmbed URL value should make that editable.
Can add oEmbed URL on 'Descriptions' pane, under Title.
Should only be available when a value exists, not allow new URLs to be created, since we limit to either oEmbed URL or content media.

Related work

Link to related tickets or prior related work here.

Accessibility Concerns

Add any information here to indicate any known or suspected accessibility issues for this ticket

@wickr wickr added the Features Issues related to building and enhancing features label Oct 16, 2024
@megwalt megwalt self-assigned this Oct 17, 2024
@wickr
Copy link
Member Author

wickr commented Oct 23, 2024

@megwalt FYI, I had forgotten about this (partly because the oembed dashboard on staging wasn't working) but there is an 'Edit oEmbed' page linked from Manage oEmbeds. https://staging.oregondigital.org/oembeds/8049g5150/edit?locale=en

I don't know what that means for this ticket? Could just link from the FileSet edit page to this page. Or if you're far enough along and want to continue, I don't think it'd be a bad thing to have FileSet form have it too.

@megwalt
Copy link
Contributor

megwalt commented Oct 23, 2024

@wickr I think that I'll still look into getting the field onto the FileSet, but if it ends up being more complicated than expected, I will pivot to a link.

@megwalt megwalt linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Features Issues related to building and enhancing features
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants