From ac5037aef49d3805214e2492847baffa30f25a77 Mon Sep 17 00:00:00 2001 From: Will Beasley Date: Tue, 22 Oct 2024 18:45:21 -0500 Subject: [PATCH] update news & cran-comments ref #547 --- NEWS.md | 5 ++--- cran-comments.md | 49 +++++++++--------------------------------------- 2 files changed, 11 insertions(+), 43 deletions(-) diff --git a/NEWS.md b/NEWS.md index 8e20f056..4002ad1b 100644 --- a/NEWS.md +++ b/NEWS.md @@ -10,14 +10,13 @@ Quick links: * [Current & previous GitHub Issues](https://github.com/OuhscBbmc/REDCapR/issues?q=is%3Aissue) * [Documentation for current GitHub version](https://ouhscbbmc.github.io/REDCapR/) -Version 1.3.x (Not yet released on CRAN) +Version 1.3.0 (released 2024-10-22) ========================================================== -These features are not yet on CRAN. Install with `remotes::install_github("OuhscBbmc/REDCapR")` - ### Minor Enhancements * Redirection layer for test suite allows you to plug in your own server (#539, #542, #544) +* Skip a test when checked on CRAN servers (but not on local or GitHub Action machines) Version 1.2.0 (released 2024-09-08) ========================================================== diff --git a/cran-comments.md b/cran-comments.md index e487596d..13382ee7 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,7 +1,8 @@ Description =============================================== -This submission is primarily to address a change in the REDCap server. A lot of packages additions in the meantime were building up. +This submission is primarily to address a failing test. +One of the test (out of hundreds) was missing `testthat::skip_on_cran()`. Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN. -Will Beasley @@ -11,53 +12,21 @@ Test environments 1. Local Ubuntu, R 4.4.1 2. Local Win11, R 4.4.1 patched 3. R-hub - 1. [Ubuntu Linux, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/10748844649/job/29817754743) - 2. [Windows Server, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/10748844649/job/29817754878) - 3. [MacOS, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/10748844649/job/29817754969) -4. [win-builder](https://win-builder.r-project.org/6a44Y48qLSlw/), development version. + 1. [Ubuntu Linux, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917444604) + 2. [Windows Server, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917445020) + 3. [MacOS, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917445170) +4. [win-builder](https://win-builder.r-project.org/7m12AMR9sIC2//), development version. 5. [GiHub Actions R-CMD-check](https://github.com/OuhscBbmc/REDCapR/actions/workflows/check-release.yaml), Ubuntu 22.04 LTS R CMD check results ----------------------------------------------- * No ERRORs or WARNINGs on any builds. -* One one Ubuntu build, there was this warning. - I don't understand the source. I'm not calling any function called `tidy()` when I search. And the two hyperlinks containing "tidy" look fine to my eye. - - ``` - ❯ checking HTML version of manual ... NOTE - Skipping checking HTML validation: no command 'tidy' found - ``` +* One NOTE: + * produced a 403 in the check, but it resolves fine in the browser. Downstream dependencies ----------------------------------------------- -With one exception, -packages that depend/import/suggest REDCapR pass the +All packages that depend/import/suggest REDCapR pass the [Reverse dependency check](https://github.com/OuhscBbmc/REDCapR/actions/workflows/recheck.yml)s. - -I worked with **tidyREDCap** team and they accepted a PR that fixes the problem: -. -It completes successfully on my local machine. - -``` -------- Check results summary ------ -Check status summary: - ERROR NOTE OK - Source packages 0 0 1 - Reverse depends 1 2 3 - -Check results summary: -REDCapR ... OK -rdepends_REDCapCAST ... OK -rdepends_REDCapDM ... NOTE -* checking data for non-ASCII characters ... NOTE -rdepends_REDCapTidieR ... OK -rdepends_ReviewR ... NOTE -* checking data for non-ASCII characters ... NOTE -rdepends_codified ... OK -rdepends_tidyREDCap ... ERROR -* checking tests ... ERROR -``` - -Results: