-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: breaking text in mobile view #4
Comments
Lines 257 to 259 in 2db6f33
Uh oh. |
Ah. This had to be added on purpose, but I'm not sure whether I tested its requirement for our repos. I had struggled a LOT with this on git_basics (Issue) and it has carried forward from there to all projects, as I'm scared of it happening again. 😅 As you correctly said:
Yes. So this essentially has to be tested on various browsers on desktops and mobiles. |
Got it. But definitely is problematic for mobile views. Not that readable. Is there a way we can break-all for links (or strings of certain lengths?)? |
Isn't that the current behaviour? 👇 Lines 257 to 259 in 2db6f33
Oh damn how would I check length using CSS? JS would be required for that and I don't think it's worth that much effort. |
I meant for HarshKapadia2/git_basics#71, for such absolute links, we can break them. Otherwise we break sentences (not words). |
Is links breaking weirdly at smaller screen sizes that much of an issue?
Well that would mean testing the page on smaller screens every time, which adds more time to add/modify something and I'm sure we'll forget to test for that (The changes on this site are pretty last minute.), realise the issue when someone points it out or one of us checks it and then we would have to go and make the change again. This is pretty cumbersome. |
It looks weird, in my opinion. |
Note: potentially has to be changed in all repos of OTC.
The text was updated successfully, but these errors were encountered: