Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: breaking text in mobile view #4

Open
tusharnankani opened this issue Oct 7, 2022 · 7 comments
Open

bug: breaking text in mobile view #4

tusharnankani opened this issue Oct 7, 2022 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tusharnankani
Copy link
Member

image

Note: potentially has to be changed in all repos of OTC.

@tusharnankani tusharnankani added bug Something isn't working good first issue Good for newcomers labels Oct 7, 2022
@tusharnankani
Copy link
Member Author

meetup/static/css/style.css

Lines 257 to 259 in 2db6f33

a {
word-break: break-all;
}

Uh oh.
Why do we have this @HarshKapadia2?

@HarshKapadia2
Copy link
Member

HarshKapadia2 commented Oct 26, 2022

Ah. This had to be added on purpose, but I'm not sure whether I tested its requirement for our repos.

I had struggled a LOT with this on git_basics (Issue) and it has carried forward from there to all projects, as I'm scared of it happening again. 😅

As you correctly said:

Note: potentially has to be changed in all repos of OTC.

Yes.

So this essentially has to be tested on various browsers on desktops and mobiles.

@tusharnankani
Copy link
Member Author

I had struggled a LOT with this on git_basics (HarshKapadia2/git_basics#71) and it has carried forward from there to all projects, as I'm scared of it happening again. 😅

Got it. But definitely is problematic for mobile views. Not that readable.

Is there a way we can break-all for links (or strings of certain lengths?)?

@HarshKapadia2
Copy link
Member

Is there a way we can break-all for links

Isn't that the current behaviour? 👇

meetup/static/css/style.css

Lines 257 to 259 in 2db6f33

a {
word-break: break-all;
}

or strings of certain lengths?

Oh damn how would I check length using CSS? JS would be required for that and I don't think it's worth that much effort.

@tusharnankani
Copy link
Member Author

I meant for HarshKapadia2/git_basics#71, for such absolute links, we can break them.

Otherwise we break sentences (not words).

@HarshKapadia2
Copy link
Member

HarshKapadia2 commented Oct 28, 2022

Is links breaking weirdly at smaller screen sizes that much of an issue?

for such absolute links, we can break them.

Well that would mean testing the page on smaller screens every time, which adds more time to add/modify something and I'm sure we'll forget to test for that (The changes on this site are pretty last minute.), realise the issue when someone points it out or one of us checks it and then we would have to go and make the change again. This is pretty cumbersome.

@tusharnankani
Copy link
Member Author

Is links breaking weirdly at smaller screen sizes that much of an issue?

It looks weird, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants