Skip to content

Commit 29144bb

Browse files
committed
Remove allow unused
1 parent fe3c700 commit 29144bb

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed

kernel/src/actions/visitors.rs

-3
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ impl RowVisitor for ProtocolVisitor {
166166
}
167167
}
168168

169-
#[allow(unused)]
170169
#[derive(Default)]
171170
#[cfg_attr(feature = "developer-visibility", visibility::make(pub))]
172171
pub(crate) struct AddVisitor {
@@ -240,7 +239,6 @@ impl RowVisitor for AddVisitor {
240239
}
241240
}
242241

243-
#[allow(unused)]
244242
#[derive(Default)]
245243
#[cfg_attr(feature = "developer-visibility", visibility::make(pub))]
246244
pub(crate) struct RemoveVisitor {
@@ -315,7 +313,6 @@ impl RowVisitor for RemoveVisitor {
315313
}
316314
}
317315

318-
#[allow(unused)]
319316
#[derive(Default)]
320317
#[cfg_attr(feature = "developer-visibility", visibility::make(pub))]
321318
#[cfg_attr(not(feature = "developer-visibility"), visibility::make(pub(crate)))]

kernel/src/path.rs

+2-12
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,12 @@ const UUID_PART_LEN: usize = 36;
2020
enum LogPathFileType {
2121
Commit,
2222
SinglePartCheckpoint,
23-
#[allow(unused)]
2423
UuidCheckpoint(String),
2524
// NOTE: Delta spec doesn't actually say, but checkpoint part numbers are effectively 31-bit
2625
// unsigned integers: Negative values are never allowed, but Java integer types are always
2726
// signed. Approximate that as u32 here.
28-
#[allow(unused)]
29-
MultiPartCheckpoint {
30-
part_num: u32,
31-
num_parts: u32,
32-
},
33-
#[allow(unused)]
34-
CompactedCommit {
35-
hi: Version,
36-
},
27+
MultiPartCheckpoint { part_num: u32, num_parts: u32 },
28+
CompactedCommit { hi: Version },
3729
Unknown,
3830
}
3931

@@ -42,9 +34,7 @@ enum LogPathFileType {
4234
#[cfg_attr(not(feature = "developer-visibility"), visibility::make(pub(crate)))]
4335
struct ParsedLogPath<Location: AsUrl = FileMeta> {
4436
pub location: Location,
45-
#[allow(unused)]
4637
pub filename: String,
47-
#[allow(unused)]
4838
pub extension: String,
4939
pub version: Version,
5040
pub file_type: LogPathFileType,

kernel/tests/common/mod.rs

-2
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ pub(crate) fn test_read(
8484
Ok(())
8585
}
8686

87-
// TODO (zach): this is listed as unused for acceptance crate
88-
#[allow(unused)]
8987
pub(crate) fn read_scan(scan: &Scan, engine: Arc<dyn Engine>) -> DeltaResult<Vec<RecordBatch>> {
9088
let scan_results = scan.execute(engine)?;
9189
scan_results

0 commit comments

Comments
 (0)