Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[News] - resize image to fill the window - is now on Mid-Mouse Button & Tab & Enter #460

Open
Owyn opened this issue Dec 12, 2021 · 11 comments
Labels

Comments

@Owyn
Copy link
Owner

Owyn commented Dec 12, 2021

After some time using resizing function I came up with a more handy method I believe

resize image to fill the window - is now on Middle Mouse Button & Tab & Enter hotkeys

I hope you find it there now without problems 😀

(but in case you don't - here's the issue I created, I hope it helps)

@JenieX
Copy link
Contributor

JenieX commented Apr 6, 2022

In this video of this page, middle clicking the image would make more sense to toggle the zoom to the original state, the state which the image fits the whole window perfectly. Is this an issue of something you put intentionally?

@Owyn
Copy link
Owner Author

Owyn commented Apr 6, 2022

more sense to toggle the zoom to the original state
if your original state is original image size then it does exactly that,
else you can just double-left-click to get to the image fit to window state,

it toggles between original image size and filling
and left click toggles between original image size and fit

every toggle toggles between original image size and new one, so it's by design I guess

if for that particular image for this particular person it makes more sense to work differently - it might not for everything & everyone else 🤷‍♀️
e.g. https://www.imagebam.com/view/ME95DK1 - I think current behavior is preferable for this image

@JenieX
Copy link
Contributor

JenieX commented Apr 6, 2022

Didn't actually know about the left click, now it makes sense. Thank you!

@JenieX
Copy link
Contributor

JenieX commented Apr 7, 2022

Okay, one more thing please.
Would you consider the idea of having middle click to toggle between the three states, original, fit, and fill?

@Owyn
Copy link
Owner Author

Owyn commented Apr 7, 2022

Okay, one more thing please. Would you consider the idea of having middle click to toggle between the three states, original, fit, and fill?

No? because that's how it was on left click before middle click (+ tab) got introduced separately, that's the whole point of them to have separate actions...

mouse buttons aren't that far away, just use both buttons

p.s. - if you absolutely want something changed - there's "custom js" setting where you can write your own zoom function in javascript 🤷‍♀️

@JenieX
Copy link
Contributor

JenieX commented Apr 7, 2022

Okay, one more thing please. Would you consider the idea of having middle click to toggle between the three states, original, fit, and fill?

No? because that's how it was on left click before middle click (+ tab) got introduced separately, that's the whole point of them to have separate actions...

mouse buttons aren't that far away, just use both buttons

p.s. - if you absolutely want something changed - there's "custom js" setting where you can write your own zoom function in javascript 🤷‍♀️

I know that actually. But I use NoScript with every websites set to not load JS by default. That prevents the using of the eval function. I know your script stops everything on supported websites, but I can't count on it for surfing the web.

@Owyn
Copy link
Owner Author

Owyn commented Apr 7, 2022

script stops everything on supported websites

well yes, but not on all of them - if on some site image can't load without the js - it is set to not get js disabled there.

weird, I have noscript too but can't seem to find the eval blocking option, and my eval works fine

p.s. - you're just breaking things for yourself, not actually protecting yourself much with eval block

p.p.s. - try nextdns dns filtering to get rid of most known harmful malwares and scripts

@JenieX
Copy link
Contributor

JenieX commented Apr 7, 2022

weird, I have noscript too but can't seem to find the eval blocking option, and my eval works fine

Not if you have that image website to Untrusted, which is the default setting that I like. At least for me.

p.s. - you're just breaking things for yourself, not actually protecting yourself much with eval block

Not about protecting myself in general, but more like saving resources. Kind of like the idea of HandyImage, and I would just create rules for every website I visit, to load things that are necessary and I want.

@JenieX
Copy link
Contributor

JenieX commented Apr 17, 2022

I'm in the process of building a script, similar to Mouseover Popup Image Viewer, but very basic and simple. Actually, it kind of combines your script and MPIV ideas.
I'll be using some of the tricks you have in your script, I hope you don't mind.

@Owyn
Copy link
Owner Author

Owyn commented Apr 17, 2022

@FlowerForWar
good luck

if you have handyimage installed, it can run in iframes, so you could could probably just make pop-up viewing windows directly iframe to image hosting links and handyimage would do the rest

@JenieX
Copy link
Contributor

JenieX commented Apr 17, 2022

@FlowerForWar good luck

if you have handyimage installed, it can run in iframes, so you could could probably just make pop-up viewing windows directly iframe to image hosting links and handyimage would do the rest

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants