-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT3X expected time zone behaviour #198
Comments
Ok getting things right for GT3X is really tricky because we need to accommodate two versions. The below is my first attempt: For V1:
Test cases for V1: java AccelerometerParser Tests/Resources/gt3xV1.gt3x npyOutput:True # reference
java AccelerometerParser Tests/Resources/gt3xV1.gt3x npyOutput:True rawOutput:True timeZone:Asia/Shanghai # npy doesn't change but epoch file moves forward by 7 hours
java AccelerometerParser Tests/Resources/gt3xV1.gt3x npyOutput:True rawOutput:True timeZone:Asia/Shanghai offsetHour:08:00:00 # npy moves forward by 7 hours but epoch time is the same at the reference time So it turns out that GT3X V2 also stores the UNIX time in local time format despite their email correspondence claims that the timestamps are stored in local time. Think this is likely a legacy issue from the C# tick time format. It is wrong and confusing to store timestamps in local time in a UNIX time. For V2:
This leaves both parsing for V1 and V2 the same. Since we both only know the local time, java AccelerometerParser Tests/Resources/gt3xV1.gt3x npyOutput:True # reference
java AccelerometerParser Tests/Resources/gt3xV1.gt3x npyOutput:True rawOutput:True timeZone:Asia/Shanghai # npy doesn't change but epoch file moves forward by 7 hours
java AccelerometerParser Tests/Resources/gt3xV1.gt3x npyOutput:True rawOutput:True timeZone:Asia/Shanghai offsetHour:08:00:00 # npy moves forward by 7 hours but epoch time is the same at the reference time |
@angerhang I think the fix for this would be similar to your recent fix to GENEA devices? Or are they different case? |
At the moment, it is a bit unclear in terms of how to deal with the GT3X, time zone, day light saving and what parameters to pass in. Related issues are: wadpac/GGIR#580 and actigraph/GT3X-File-Format#20.
Will update the processing for GT3X time zone in the due course.
The text was updated successfully, but these errors were encountered: