Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hfs sign test #53

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

hfs sign test #53

wants to merge 3 commits into from

Conversation

sotirova
Copy link
Contributor

Add test to check ordering of states for both positive and negative hyperfine constants.

@sotirova sotirova linked an issue Sep 13, 2022 that may be closed by this pull request
Sign of hyperfine constant breaks sorting of states #45
Open
@sotirova sotirova requested a review from hartytp September 13, 2022 18:34
@sotirova
Copy link
Contributor Author

@hartytp an overdue poke!

@hartytp
Copy link
Contributor

hartytp commented Oct 19, 2023

Could you add something in the docstring explaining what this is testing? Maybe add a reference to an issue?

Overall it LGTM, but I can't remember what bug this is checking for

@dnadlinger
Copy link
Member

#45

b32491c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartytp hartytp Awaiting requested review from hartytp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign of hyperfine constant breaks sorting of states
3 participants
@sotirova @hartytp @dnadlinger