Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser should take a Jones vector for the polarization #86

Open
hartytp opened this issue Jan 7, 2025 · 0 comments
Open

Laser should take a Jones vector for the polarization #86

hartytp opened this issue Jan 7, 2025 · 0 comments

Comments

@hartytp
Copy link
Contributor

hartytp commented Jan 7, 2025

Currently Laser takes a number (-1, 0, +1) to represent the polarization. This is fine for simple things but it would be more generally useful to take a Jones vector.

Since v1.1 we work in Jones vectors elsewhere, but I haven't yet ported the Laser class to use them.

We should fix #11 in the process.

Needs proper documentation in the docstring for Laser and tests written.

@hartytp hartytp mentioned this issue Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant