Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat with Ender Tanks (fluid multiplication issue) #582

Closed
Raidobw2 opened this issue Aug 17, 2022 · 2 comments
Closed

Compat with Ender Tanks (fluid multiplication issue) #582

Raidobw2 opened this issue Aug 17, 2022 · 2 comments

Comments

@Raidobw2
Copy link

Describe the bug
If you use (right click) an Ender Bucket from EnderTanks https://www.curseforge.com/minecraft/mc-mods/endertanks on the tank bar, it multiplies the fluid quickly and can overflow
image
image

To Reproduce

  1. Fill an Ender Bucket with at least 2 buckets' worth of a fluid
  2. Open a backpack and put the Tank Upgrade into an upgrade slot
  3. Grab the Ender Bucket in the inventory GUI and hover over the tank in the backpack
  4. Right-click on the tank. It should now have 1,000mB worth of fluid in it
  5. Right-click on the tank again. It should now have an amount close to the amount in the Ender Bucket when you started minus 1,000mB.
  6. Keep right-clicking the tank. It will keep filling up with the amount in the previous step and will go beyond the tank limit

Expected behavior
No fluid dupe, or not having the possibility to right click with that Ender Bucket on the tank bar

Screenshots
Right click the Ender Tank against the tank bar to multiply fluids

overflow.mp4

Versions
MC 1.18.2
Forge 40.1.73
Sophisticated Backpacks sophisticatedbackpacks-1.18.2-3.18.17.680.jar
Sophisticated Core sophisticatedcore-1.18.2-0.5.1.98.jar
Ender Tanks endertanks-1.18-1.11.7.jar ( + requires lib dependency)

Relayed from FTBTeam/FTB-Modpack-Issues#1154

Thanks in advance for checking it out!

@P3pp3rF1y
Copy link
Owner

I made a minor modification on my side, but this is really an issue in ender tanks because when their fill method is called (yes in this case tank upgrade is actually trying to fill the ender bucket) they return negative value of the total amount of fluid in ender bucket. So my modification is to just ignore filled negative values, but this could be causing issues with other mods as well.

@Raidobw2
Copy link
Author

Thank you! I'll properly report this to Ender Tanks then, thank you for the information as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants