Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEI not recognizing recipes if a backpack is customized #746

Open
Twisted-Code opened this issue Apr 17, 2023 · 2 comments
Open

JEI not recognizing recipes if a backpack is customized #746

Twisted-Code opened this issue Apr 17, 2023 · 2 comments

Comments

@Twisted-Code
Copy link

Describe the bug
JEI does not recognize customize backpacks as having any recipes. If you press R (or whatever you set back JEI keybind to) while hovering over a backpack that you have applied dye to, it will not show the recipes for the underlying backpack tier. I guess it doesn't recognize the dyed backpacks as the same item?

To Reproduce
Steps to reproduce the behavior:

  1. Craft a backpack
  2. Apply dye to it through crafting
  3. hover the cursor over the dyed backpack
  4. press the key you have bound to JEI's "Show Recipe" control.
  5. nothing happens, as if the item is not craftable

Expected behavior
If possible (I know there was some discussion of your recipes being special in #532, and I really appreciate the data preservation feature FWIW), it should show the recipe corresponding to that tier of backpack.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions
Mod version that you're using. Version of forge may also be helpful in some cases

@MoePus
Copy link

MoePus commented Sep 13, 2024

public void registerItemSubtypes(ISubtypeRegistration registration) {

If you remove this override method, the problem will be solved.
But I don't know if that breaks anything.

@P3pp3rF1y
Copy link
Owner

public void registerItemSubtypes(ISubtypeRegistration registration) {

If you remove this override method, the problem will be solved.
But I don't know if that breaks anything.

that would break it - would for example display all dye recipes if you only wanted to see how that one specific color is crafted

I am afraid this ticket can't be solved without changes to JEI because as it works currently this would require registration of recipes for items with every single color combination that can exist for backpacks and that is several quintillion (4.6e+18) of items. I can see if mezz would have ideas of how a support for something like this could be added, but doubt he would want to change one of the core JEI things just to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants