Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the user/wallet creation process #25

Closed
dappsar opened this issue Sep 10, 2024 · 0 comments · Fixed by #279, #280, #283 or #289
Closed

Improve the user/wallet creation process #25

dappsar opened this issue Sep 10, 2024 · 0 comments · Fixed by #279, #280, #283 or #289
Assignees
Labels
enhancement New feature or request wallet-creation
Milestone

Comments

@dappsar
Copy link
Collaborator

dappsar commented Sep 10, 2024

User Duplication

  • Issue: The code checks if a user already exists but doesn't handle cases where the process is interrupted between the verification and the wallet creation, potentially leading to duplicate users.
  • Improvement: Implement database transactions to ensure atomicity of the process, or use mechanisms like optimistic locking to prevent duplication.

Lack of Robust Phone Number Verification

  • Issue: Phone numbers are validated only by their length, which may lead to inconsistencies if malformed numbers are entered.
  • Improvement: Implement more robust phone number validation, such as enforcing the E.164 format.

Lack of Robust Error Handling (related with: #26)

  • Issue: In several parts of the code, such as wallet creation or token issuance, error handling is not properly implemented, which can result in unexpected failures.
  • Improvement: Enhance error handling and fallbacks to ensure that failures are logged and managed properly without compromising the user flow.
@dappsar dappsar added enhancement New feature or request wallet-creation labels Sep 10, 2024
@dappsar dappsar added this to the MVP milestone Sep 10, 2024
@dappsar dappsar changed the title WALLET-CREATION: Improve the user generation process with wallet Improve the user/wallet creation process Sep 17, 2024
@dappsar dappsar assigned dappsar, TomasDmArg and gonzageraci and unassigned dappsar Sep 17, 2024
@dappsar dappsar assigned dappsar and unassigned TomasDmArg and gonzageraci Jan 10, 2025
@dappsar dappsar closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment