Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for cartesian grids netcdf load/save with isotopes #149

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

sjdaines
Copy link
Member

  • function cartesian_to_internal(grid::CartesianLinearGrid, griddata::AbstractArray) strip out missing that will have been added by internal_to_cartesian

- function cartesian_to_internal(grid::CartesianLinearGrid, griddata::AbstractArray)
      strip out missing that will have been added by internal_to_cartesian
@sjdaines sjdaines merged commit 67b590c into main Dec 22, 2024
3 checks passed
@sjdaines sjdaines deleted the grid_missing_fix branch December 22, 2024 12:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.54%. Comparing base (9135e8a) to head (8b43f54).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/Grids.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   54.88%   55.54%   +0.65%     
==========================================
  Files          39       41       +2     
  Lines        4267     4366      +99     
==========================================
+ Hits         2342     2425      +83     
- Misses       1925     1941      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants