Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TrieSet memory efficiency #65

Open
rovarga opened this issue Sep 18, 2019 · 0 comments
Open

Improve TrieSet memory efficiency #65

rovarga opened this issue Sep 18, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@rovarga
Copy link
Collaborator

rovarga commented Sep 18, 2019

Current implementation of TrieSet works with a backing TrieMap, which works just fine, but is not completely memory-efficient because we allocate SNodes for values (and LNodes for key/value pairs).
Given we are always storing Booleans, we should be able to specialize to not hold values -- which means the TrieMap infra would be duplicated to specialize for TrieSet case.
This will lead to code duplication, which is a maintenance and UT burden, but the result would be more memory-efficient TrieSet.

@rovarga rovarga added the enhancement New feature or request label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant