Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub/sup should not be reset in the first place #12

Open
Petah opened this issue Jun 5, 2013 · 1 comment
Open

Sub/sup should not be reset in the first place #12

Petah opened this issue Jun 5, 2013 · 1 comment

Comments

@Petah
Copy link
Contributor

Petah commented Jun 5, 2013

Sub/sup should not be reset in the first place, i.e. you are resetting the reset.

https://github.com/PANmedia/OnionKnight/blob/master/base/tags.scss#L158-L164

@tbredin
Copy link
Contributor

tbredin commented Jun 18, 2013

If we want to fix this we'll need to write our own (limited) reset, as this comes from the compass reset.

However, this currently leaves us with sup/sub tags that are nicely normalised across browsers, I don't see this being a big issue unless you're wanting to set further styles on these tags (do we really need to?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants