Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper handling of parameter bounds in prior / startpoint sampling #330

Open
dweindl opened this issue Dec 4, 2024 · 0 comments · May be fixed by #335
Open

Proper handling of parameter bounds in prior / startpoint sampling #330

dweindl opened this issue Dec 4, 2024 · 0 comments · May be fixed by #335
Assignees
@dweindl

Comments

@dweindl
Copy link
Member

dweindl commented Dec 4, 2024

Currently, when sampled startpoints are outside the bounds, their value is set to the upper/lower bounds. This may put too much probability mass on the bounds. The problem is illustrated in https://petab--329.org.readthedocs.build/projects/libpetab-python/en/329/example/distributions.html. This should instead be handled by sampling from the respective truncated distributions (which we anyways want to support in PEtab2).
@dweindl dweindl self-assigned this Dec 7, 2024
@dweindl dweindl linked a pull request Dec 7, 2024 that will close this issue
Open
dweindl added a commit to dweindl/libpetab-python that referenced this issue Dec 11, 2024
@dweindl
Implement proper truncation for prior distributions
f4b5153 
Currently, when sampled startpoints are outside the bounds, their value is set to the upper/lower bounds. This may put too much probability mass on the bounds.

With these changes, we properly sample from the respective truncated distributions.

Closes PEtab-dev#330.
dweindl added a commit to dweindl/libpetab-python that referenced this issue Dec 11, 2024
@dweindl
Implement proper truncation for prior distributions
2fd6da8 
Currently, when sampled startpoints are outside the bounds, their value is set to the upper/lower bounds. This may put too much probability mass on the bounds.

With these changes, we properly sample from the respective truncated distributions.

Closes PEtab-dev#330.
@dweindl dweindl linked a pull request Dec 11, 2024 that will close this issue
Implement proper truncation for prior distributions #335
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement proper truncation for prior distributions dweindl/libpetab-python
1 participant
@dweindl