-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add condition GeoBoundingBoxCondition
#365
Comments
Thx for the issue and the links to the different engines 👍 |
Some research data not complete yet how different search engines do a bounding box query or polygon based queries:
Meilisearch expected Top Right -> Bottom Left, while most others go on Top Left and Bottom Right. Polygon based queries are normally counter clockwise (right handed rule) but they seems in most cases just use the shortest distance. Lot of documentation reference for polygon search also Well Known text representation of geometry https://en.wikipedia.org/wiki/Well-known_text_representation_of_geometry |
Interesting info MapBox uses Top Right (northEast) and Bottom Left (southWest): https://docs.mapbox.com/help/glossary/bounding-box/ Same for Google maps uses: https://developers.google.com/maps/documentation/javascript/reference/coordinates#LatLngBounds It seems also why Meilisearch changed its behaviour to make things maybe easier in JS as you can then directly forward them to filter correctly: meilisearch/specifications#223 |
moved the missing part (RediSearch) into own ticket: #422 |
I open this issue following my PR (#420) to introduce a new
GeoBoundingBoxCondition
condition. According to my research, almost all search engines seem to support geographic search within a bounding box. Only Loupe does not implement this feature yet.For the moment, I've only implemented it on
Meilisearch
.The text was updated successfully, but these errors were encountered: