Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elasticsearch / Opensearch] Recheck the usage of doc_values for filtering #65

Open
alexander-schranz opened this issue Jan 9, 2023 · 0 comments
Labels
Adapter: Elasticsearch Elasticsearch Adapter releated issue Adapter: Opensearch Opensearch Adapter related issue External Issue A issue which need to be solved in upstream repository first.

Comments

@alexander-schranz
Copy link
Member

alexander-schranz commented Jan 9, 2023

Currently we are using doc_values to true for filtering none indexed fields. This is documented as not being as performant as query indexed fields: https://www.elastic.co/guide/en/elasticsearch/reference/current/doc-values.html. Which we maybe need to recheck.

Interesting is that Opensearch and Elasticseach has different default values which did make tests fail in Opensearch for #64 (commit) and required to set doc_values to true there:

Opensearch: doc_values: false doc here
Elasticsearch: doc_values: true doc here

Update the doc_values: true set on opensearch did not work like expected: opensearch-project/OpenSearch#5770

Currently in opensearch we workaround making all filterable fields also index. This should be rechecked if this should also be the behaviour for elasticsearch. This maybe requires us to switch from query_string search to match search where we put only searchable fields into it.

@alexander-schranz alexander-schranz added Adapter: Elasticsearch Elasticsearch Adapter releated issue Adapter: Opensearch Opensearch Adapter related issue External Issue A issue which need to be solved in upstream repository first. labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adapter: Elasticsearch Elasticsearch Adapter releated issue Adapter: Opensearch Opensearch Adapter related issue External Issue A issue which need to be solved in upstream repository first.
Projects
None yet
Development

No branches or pull requests

1 participant