From bc5b3b362c7e2303f82064ba3ceee513f38af466 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Fri, 8 Nov 2024 14:10:22 +0100 Subject: [PATCH] GH Actions: use explicit PHPStan major This Monday, [PHPStan 2.0 will be released](https://phpc.social/@OndrejMirtes/113441109253809720). I've done some preliminary scans with PHPStan 2.0-dev to check if this would have an impact on this codebase and as things are, this would mean the build would start to fail. For now, I'm proposing to make a small change in the GH Actions workflow to explicitly use PHPStan 1.x. This buys us some time to evaluate PHPStan 2.0 properly and to make any changes needed to make the codebase compatible with PHPStan 2.x when we're ready for it. Note: At least one of the new issues reported has been identified as a bug and reported to PHPStan: https://github.com/phpstan/phpstan/issues/11980 --- .github/workflows/basics.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/basics.yml b/.github/workflows/basics.yml index 84e5b2a..f753c1a 100644 --- a/.github/workflows/basics.yml +++ b/.github/workflows/basics.yml @@ -102,6 +102,8 @@ jobs: phpstan: name: "PHPStan" uses: PHPCSStandards/.github/.github/workflows/reusable-phpstan.yml@main + with: + phpstanVersion: '1.x' remark: name: 'QA Markdown'