Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR Default Configurations #43

Open
jbrooksuk opened this issue Sep 22, 2014 · 3 comments
Open

PSR Default Configurations #43

jbrooksuk opened this issue Sep 22, 2014 · 3 comments

Comments

@jbrooksuk
Copy link
Contributor

We should add support for PSR-2 Coding Standards and potentially use this as the default standards if none are supplied.

@jbrooksuk
Copy link
Contributor Author

I suggest that we do this after #27 so that the new files don't also need to be modified.

@hafah
Copy link
Contributor

hafah commented Mar 5, 2018

got this quite a lot on private functions:

name should follow the pattern /^_[a-z][a-zA-Z0-9]*$/

which is agains PSR-2 "4.3. Methods". So I wonder how to set phpcheckstyle to PSR-2

@IGNBPesty
Copy link
Contributor

Yes, this is old school naming.

You can edit the config file and change the "privateFunctionNaming" rule to remove the underscore.

<test name="privateFunctionNaming" regexp="/^_[a-z][a-zA-Z0-9]*$/" level="error"/>

==>

<test name="privateFunctionNaming" regexp="/^[a-z][a-zA-Z0-9]*$/" level="error"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants