Add faster shield sync #430
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
tACK 9284d8a
Seriously powerful improvement, speed is subjective, but even in my sub-par speed environment, a 3-4x improvement is minimally visible, I imagine this will be even better for faster connections given there's no more constant TCP-handshake overhead with thousands of requests, but a single stream.
There was a problem hiding this comment.
Works really good and sync time is much faster.
I left a couple of nits and a question about why some bytes of the stream are not parsed.
The logic surely needs a big refactor (in particular we should split the part of receiving the stream from the part of parsing it), but it can be done in another PR
| }, | ||
| blockHeights.length, | ||
| batchSize | ||
| ); | ||
| getEventEmitter().emit('shield-sync-status-update', 0, 0, true); | ||
| } catch (e) { | ||
| debugError(DebugTopics.WALLET, e); |
There was a problem hiding this comment.
for future PR: we have to change this flow
errors finish in the catch block and after that wallet is just marked as synced even if it failed
Abstract
Add faster shield sync.
This needs pivx shield and PivxNodeController updates
Testing