Implement Stake Pre-Splitting

chain_params.prod.json

@@ -32,7 +32,8 @@
         "proposalFeeConfirmRequirement": 6,
         "maxPaymentCycles": 6,
         "maxPayment": 43200000000000,
-        "defaultColdStakingAddress": "SdgQDpS8jDRJDX8yK8m9KnTMarsE84zdsy"
+        "defaultColdStakingAddress": "SdgQDpS8jDRJDX8yK8m9KnTMarsE84zdsy",
+        "stakeSplitTarget": 50000000000
     },
     "testnet": {
         "name": "testnet",
@@ -64,6 +65,7 @@
         "proposalFeeConfirmRequirement": 3,
         "maxPaymentCycles": 20,
         "maxPayment": 144000000000,
-        "defaultColdStakingAddress": "WmNziUEPyhnUkiVdfsiNX93H6rSJnios44"
+        "defaultColdStakingAddress": "WmNziUEPyhnUkiVdfsiNX93H6rSJnios44",
+        "stakeSplitTarget": 50000000000
     }
 }

chain_params.test.json

@@ -24,7 +24,8 @@
         "proposalFeeConfirmRequirement": 3,
         "maxPaymentCycles": 20,
         "maxPayment": 144000000000,
-        "defaultColdStakingAddress": "WmNziUEPyhnUkiVdfsiNX93H6rSJnios44"
+        "defaultColdStakingAddress": "WmNziUEPyhnUkiVdfsiNX93H6rSJnios44",
+        "stakeSplitTarget": 50000000000
     },
     "testnet": {
         "name": "testnet",
@@ -54,6 +55,7 @@
         "proposalFeeConfirmRequirement": 3,
         "maxPaymentCycles": 20,
         "maxPayment": 144000000000,
-        "defaultColdStakingAddress": "WmNziUEPyhnUkiVdfsiNX93H6rSJnios44"
+        "defaultColdStakingAddress": "WmNziUEPyhnUkiVdfsiNX93H6rSJnios44",
+        "stakeSplitTarget": 50000000000
     }
 }

scripts/wallet.js

@@ -1012,11 +1012,27 @@ export class Wallet {
         // Add primary output
         if (isDelegation) {
             if (!returnAddress) [returnAddress] = this.getNewAddress(1);
-            transactionBuilder.addColdStakeOutput({
-                address: returnAddress,
-                addressColdStake: address,
-                value,
-            });
+            // The per-output target for maximum staking efficiency
+            const nTarget = cChainParams.current.stakeSplitTarget;
+            // Keep track of the remainder, which is the 'unoptimal' output (or change/non-output, if too small)
+            let nRemainder = value;
+            // Generate optimal staking outputs
+            while (nRemainder > nTarget) {
+                transactionBuilder.addColdStakeOutput({
+                    address: returnAddress,
+                    addressColdStake: address,
+                    value: nTarget,
+                });
+                nRemainder -= nTarget;
+            }
+            // If the remainder is larger than one coin, we create the 'unoptimal' output
+            if (nRemainder >= COIN) {
+                transactionBuilder.addColdStakeOutput({
+                    address: returnAddress,
+                    addressColdStake: address,
+                    value: nRemainder,
+                });
+            }
         } else if (isProposal) {
             transactionBuilder.addProposalOutput({
                 hash: address,