Change bytes to num function #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Duddino
force-pushed
the
fix-shieldsync
branch
from
1fff1c9 to
3d1d6b6
Compare
JSKitty
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
tACK 3d1d6b6
In my personal testing (syncing the same seed from scratch in 5 isolated instances, in parallel and in segregated timings), I have not been able to replicate the transaction handling issue (in Firefox, the suspected browser this oddly affects).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Shield sync sometimes failed. This is because valueBalance was out of bounds.
Debugging with advanced tools such as console logs revealed that MPW always picked up the correct array, but sometimes
bytesToNumgave a wrong answer. Why and why does it only do it sometimes? I have no clue.Hopefully this fixes the issue
Testing
Sync shield a bunch of times?