-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work #4
Comments
Can you be more specific about your issue? |
Here are my chronological runs should sum it up: Run #1 broken right off the bat since this is the FIRST run, "12" seems to be some magic number here as the later runs show:
Run #2 fails because apparently unless you suddenly add the "include" switch, it sees no files in a root folder (THERE ARE 74 FILES IN MY D: ROOT):
Run #3, now only after adding include does it see the files as "processed"? No, they never were so it should have added far more than the 12 existing but shows how broken the logic is (THERE ARE 74 FILES IN MY D: ROOT):
Run #4, let's give it a huge folder structure to scan:
As you can see...very broken. |
Code comment: Reading the subsequent code, your logic is totally broken. Once it sees a XML file exists, it will never add new entries. In addition, checking for the path ending in a slash breaks the ability to start at a root drive folder. Also, the logic on checking for a wildcard for "include" is broken. Once it reads the existing XML, it then erroneously dumps that same XML into whatever path you scan. I scanned 4 paths, each now has a duplicate copy of the first XML (the one run that added anything). I don't see how there is any way this could have been tested before publishing it. |
Not sure how you possibly tested this before publishing in the gallery...no matter what directory I give it after I hash my temp folder, it adds no new files doesn't honor recurse simply doesn't work. Would love this if it worked!
The text was updated successfully, but these errors were encountered: