Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it a mistake to get patch_num_h from w? #48

Closed
21makunyang opened this issue Jul 3, 2024 · 1 comment
Closed

Is it a mistake to get patch_num_h from w? #48

21makunyang opened this issue Jul 3, 2024 · 1 comment

Comments

@21makunyang
Copy link

Hi, is it a mistake to get patch_num_h from w at line 33 in Chat-UniVi/visualization.py?

h, w, _ = img.shape

patch_num_h, patch_num_w = w // patch_size, w // patch_size

Is it supposed to be like this?
patch_num_h, patch_num_w = h // patch_size, w // patch_size

@jpthu17
Copy link
Member

jpthu17 commented Jul 5, 2024

Thanks for pointing out the bug, I've fixed it.

@jpthu17 jpthu17 closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants