Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GATK4 tool IDS #90

Open
illusional opened this issue Jan 20, 2021 · 0 comments
Open

Refactor GATK4 tool IDS #90

illusional opened this issue Jan 20, 2021 · 0 comments

Comments

@illusional
Copy link
Member

Currently, it's up to each GATK4 tool to declare it's own tool(self): -> str, it would be much better (way more consistent), if the Gatk4 tool base declared the ID as:

class Gatk4ToolBase(BioinformaticsTool, ABC):
    def tool(self) -> str:
        return "Gatk4" + self.gatk_command()
    # other tool definitions

Removing the other GATK def tool lines from the GATK tools is the time-consuming bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant