Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain argument to GenericTransport (default="all") #2430

Open
ma-sadeghi opened this issue May 14, 2022 · 1 comment
Open

Add domain argument to GenericTransport (default="all") #2430

ma-sadeghi opened this issue May 14, 2022 · 1 comment

Comments

@ma-sadeghi
Copy link
Member

ma-sadeghi commented May 14, 2022

This would eventually add the ability to properly run simulations on part of the network. For starters, though, we could only return a masked array (interleaved with nans at locations outside the desired domain).

Example use case in PEMFC

Proton conduction in ionomer phase coupled with oxygen diffusion in ionomer + air

Note

Properly supporting this feature (assemble a smaller A matrix, etc.) has performance benefits, for example, running a simulation on half of the network could become ~8 times faster.

@jgostick jgostick added this to the v3+ - Future Enhancements milestone May 22, 2022
@jgostick
Copy link
Member

We can add this as a feature in the future, so I have given it the 3+ milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants