Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify residual invading phase in drainge, imbibition, and ip #2486

Open
3 tasks
jgostick opened this issue Jun 25, 2022 · 0 comments
Open
3 tasks

Comments

@jgostick
Copy link
Member

I had to remove this capability during the recent refactor since the handling of trapping was quite tricky in the presence of residual invading phase. I basically declared this as a future feature we'll add, which is why I'm creating this issue. Below are a few points:

  • The ability/desire to specify results pores AND throats complicates things. The percolation algorithms assume that invasion/filling happens in certain order, like "invaded throat, filled attached pore", but specifying the residual could contradtict this and break some logical assumptions.
  • In IP, the residual pores need to be noted separately and IF/WHEN they get reconnected, THEN their throats need to be added to the queue. If residual throats are specified, then I'm not quite sure how to deal with them...are the attached pores set to invaded immediately?
  • In drainage, the residual pore are included in the percolation without any extra thought. Trapping is tricky though...what if 2 pores are filled with invaded phase, but their shared throat is not? This throat would be trapped, but this is not how the trapping check works.

Basically, including residual seems like it will require a long list of special cases/checks to properly catch trapping, which seems like a bad design. We need to find a more universal/robust way.

@jgostick jgostick added this to the v3+ - Future Enhancements milestone Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant