Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back remove and purge_object methods #2555

Open
mkaguer opened this issue Aug 24, 2022 · 3 comments
Open

Add back remove and purge_object methods #2555

mkaguer opened this issue Aug 24, 2022 · 3 comments

Comments

@mkaguer
Copy link
Contributor

mkaguer commented Aug 24, 2022

These methods would have been handy for me recently. Would we consider adding these back? I ran into a situation where my algorithm was not running do to nans in the conductance model. It was a problem with the geometry. So to trouble shoot I wanted to export to paraview, but when I tried exporting the project I couldn't because the algorithm had not been run yet! (The reason why it can't export is because there is no alg.soln, which project_to_xdmf uses to see if it contains transient data or not.) So anyway I wanted to simply delete the algorithm and export without it but there was no way of doing this. But perhaps the problem is with how we check for transient data on our algs.

@ma-sadeghi
Copy link
Member

Yes, I think as you mentioned yourself, the problem is how we check for transient data, so I'd say that needs to be refactored.

@ma-sadeghi ma-sadeghi changed the title Add back remove() and purge_object() methods Add back remove and purge_object methods Sep 2, 2022
@jgostick
Copy link
Member

I have actually fixed this sorta...the Transport alg now puts soln = {} on self during init, so this allows you to export even if the alg has not been run.

@jgostick jgostick added this to the v3+ - Future Maintenance milestone Sep 21, 2022
@mkaguer
Copy link
Contributor Author

mkaguer commented Sep 21, 2022

I like that solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants