Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max tasks should be set to 14 in policies.py #2

Open
akfreed opened this issue Aug 1, 2019 · 0 comments
Open

Max tasks should be set to 14 in policies.py #2

akfreed opened this issue Aug 1, 2019 · 0 comments

Comments

@akfreed
Copy link
Member

akfreed commented Aug 1, 2019

"MAX_TASKS = 20 "
This is not correct, it should be 14 to match the lower levels of the stack.

The reason for this is that the Ring 0 Manager will put all C struct tasks on a single 4K page for the SMM Inspector to read/write and currently, the size of tasks is 272 bytes. While technically 15 tasks would fit on a page, the limit has been currently set to 14 in case of growth. Note, if more tasks need to be in a bin, the Ring 0 Manager and SMM Inspector could be modified to place/read data from more than one 4K page using a mechanism similar to the STM's page continuation feature but so far this hasn't been an issue.
--@bdelgado1995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant