Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JointTrajectoryAction server doesn't abort all goals properly #366

Open
calderpg opened this issue May 23, 2013 · 0 comments
Open

JointTrajectoryAction server doesn't abort all goals properly #366

calderpg opened this issue May 23, 2013 · 0 comments

Comments

@calderpg
Copy link

In the joint_trajectory_action JointTrajectoryExecuter class, in the function controllerStateCB, the following code executes if the end time of the goal has been reached:

      if (inside_goal_constraints)
      {
        active_goal_.setSucceeded();
        has_active_goal_ = false;
      }
      else if (now < end_time + ros::Duration(goal_time_constraint_))
      {
        // Still have some time left to make it.
      }
      else
      {
        ROS_WARN("Aborting because we wound up outside the goal constraints");
        active_goal_.setAborted();
        has_active_goal_ = false;
      }

The final else block appears to abort the goal, however it doesn't also stop the trajectory controller as used elsewhere in the class:

          // Stops the controller.
          trajectory_msgs::JointTrajectory empty;
          empty.joint_names = joint_names_;
          pub_controller_command_.publish(empty);

          active_goal_.setAborted();
          has_active_goal_ = false;
          ROS_WARN("Aborting because we would up outside the trajectory constraints");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant