Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use S3 class for the external point and add checks to API #8

Closed
fikovnik opened this issue Aug 25, 2022 · 2 comments
Closed

Use S3 class for the external point and add checks to API #8

fikovnik opened this issue Aug 25, 2022 · 2 comments
Assignees
@programLyrique

Comments

@fikovnik
Copy link
Member

The pointer open_db returns should have a class and all the API functions should check that the db argument is proper. Currently, it segfaults if you pass there anything else.
@programLyrique
Copy link
Collaborator

The external ptr also has a specific tag that one can check.
However, adding a class name would help for #6

@programLyrique programLyrique self-assigned this Aug 25, 2022
@programLyrique
Copy link
Collaborator

programLyrique commented Sep 2, 2022 •
edited
Loading

The external pointer now has a class, which is used for the S3 API (0f91baf)
Checks are performed directly on the internal tag of the external pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programLyrique programLyrique

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fikovnik @programLyrique