From 3be1c08286be1cf9a7e7d368cc1492b4b4640237 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sun, 8 Dec 2024 16:12:40 -0500
Subject: [PATCH 01/12] Override enclosure url and/or prefix

---
 app/models/enclosure_url_builder.rb             | 13 +++++++++++--
 ...42_add_enclosure_override_url_to_episodes.rb |  6 ++++++
 db/schema.rb                                    |  4 +++-
 test/models/enclosure_url_builder_test.rb       | 17 ++++++++++++++++-
 4 files changed, 36 insertions(+), 4 deletions(-)
 create mode 100644 db/migrate/20241208194342_add_enclosure_override_url_to_episodes.rb

diff --git a/app/models/enclosure_url_builder.rb b/app/models/enclosure_url_builder.rb
index b794456ad..22c5b5988 100644
--- a/app/models/enclosure_url_builder.rb
+++ b/app/models/enclosure_url_builder.rb
@@ -21,8 +21,17 @@ def podcast_episode_url(podcast, episode, feed = nil)
     feed ||= podcast.default_feed
     prefix = feed.try(:enclosure_prefix)
 
-    url = base_enclosure_url(podcast, episode, feed)
-    enclosure_prefix_url(url, prefix)
+    base_url = if !episode.enclosure_override_url.blank?
+      episode.enclosure_override_url
+    else
+      base_enclosure_url(podcast, episode, feed)
+    end
+
+    if episode.enclosure_override_prefix
+      base_url
+    else
+      enclosure_prefix_url(base_url, prefix)
+    end
   end
 
   def base_enclosure_url(podcast, episode, feed)
diff --git a/db/migrate/20241208194342_add_enclosure_override_url_to_episodes.rb b/db/migrate/20241208194342_add_enclosure_override_url_to_episodes.rb
new file mode 100644
index 000000000..f78fddfe1
--- /dev/null
+++ b/db/migrate/20241208194342_add_enclosure_override_url_to_episodes.rb
@@ -0,0 +1,6 @@
+class AddEnclosureOverrideUrlToEpisodes < ActiveRecord::Migration[7.2]
+  def change
+    add_column :episodes, :enclosure_override_url, :string
+    add_column :episodes, :enclosure_override_prefix, :boolean
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
index c6e3e4bd9..523fd862e 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.2].define(version: 2024_11_20_165556) do
+ActiveRecord::Schema[7.2].define(version: 2024_12_08_194342) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
   enable_extension "uuid-ossp"
@@ -165,6 +165,8 @@
     t.integer "medium"
     t.integer "lock_version", default: 0, null: false
     t.string "categories", array: true
+    t.string "enclosure_override_url"
+    t.boolean "enclosure_override_prefix"
     t.index ["categories"], name: "index_episodes_on_categories", using: :gin
     t.index ["guid"], name: "index_episodes_on_guid", unique: true
     t.index ["keyword_xid"], name: "index_episodes_on_keyword_xid", unique: true
diff --git a/test/models/enclosure_url_builder_test.rb b/test/models/enclosure_url_builder_test.rb
index a73b3d3dc..333b6a6f7 100644
--- a/test/models/enclosure_url_builder_test.rb
+++ b/test/models/enclosure_url_builder_test.rb
@@ -5,7 +5,7 @@
   let(:template) { "https://#{ENV["DOVETAIL_HOST"]}/{slug}/{guid}/{original_filename}" }
   let(:prefix) { "http://www.podtrac.com/pts/redirect.mp3/media.blubrry.com/jojego/" }
   let(:podcast) { create(:podcast, enclosure_prefix: prefix, enclosure_template: template) }
-  let(:episode) { create(:episode_with_media, podcast: podcast, prx_uri: "/api/v1/stories/87683") }
+  let(:episode) { create(:episode_with_media, podcast: podcast) }
   let(:feed) { create(:feed, podcast: podcast, slug: "no-ads-pls") }
   let(:builder) { EnclosureUrlBuilder.new }
 
@@ -118,6 +118,21 @@
     _(url).must_match(/http:\/\/www.podtrac.com\/pts\/redirect.mp3\/media.blubrry.com\/jojego\/dovetail.prxu.org\/#{podcast.id}\/ba047dce-9df5-4132-a04b-31d24c7c55a(\d+)\/audio\.mp3/)
   end
 
+  it "can make an enclosure url for an override url, but not override prefix" do
+    episode.enclosure_override_url = "https://a.io/a.mp3"
+    episode.enclosure_override_prefix = false
+
+    url = builder.podcast_episode_url(podcast, episode)
+    _(url).must_equal("http://www.podtrac.com/pts/redirect.mp3/media.blubrry.com/jojego/a.io/a.mp3")
+  end
+  it "can make an enclosure url for an override url, also override prefix" do
+    episode.enclosure_override_url = "https://a.io/a.mp3"
+    episode.enclosure_override_prefix = true
+
+    url = builder.podcast_episode_url(podcast, episode)
+    _(url).must_equal("https://a.io/a.mp3")
+  end
+
   it "applies template to audio file link" do
     podcast.enclosure_prefix = nil
     podcast.enclosure_template = "http://foo.com/r{extension}/b/n/{host}{+path}"

From d8d454cfdd2f158ec0521f680ed6fe8b133c1875 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Tue, 10 Dec 2024 09:05:12 -0500
Subject: [PATCH 02/12] Refactor episode media, add override medium

---
 app/controllers/episode_media_controller.rb   |   2 +
 app/helpers/episodes_helper.rb                |   4 +-
 app/models/concerns/episode_media.rb          | 132 +++++++++++++++++-
 app/models/episode.rb                         |  79 -----------
 app/models/external_media_resource.rb         |  34 +++++
 app/models/tasks/analyze_media_task.rb        |  43 ++++++
 app/views/episode_media/_form.html.erb        |  16 +++
 app/views/episode_media/_form_main.html.erb   |   3 +-
 app/views/episode_media/_form_status.html.erb |   2 +-
 .../episodes/_form_distribution.html.erb      |   2 +-
 config/locales/en.yml                         |   1 +
 test/models/episode_test.rb                   |   3 +-
 test/models/external_media_resource_test.rb   |   7 +
 13 files changed, 235 insertions(+), 93 deletions(-)
 create mode 100644 app/models/external_media_resource.rb
 create mode 100644 app/models/tasks/analyze_media_task.rb
 create mode 100644 test/models/external_media_resource_test.rb

diff --git a/app/controllers/episode_media_controller.rb b/app/controllers/episode_media_controller.rb
index a8b595ede..c7aefad5f 100644
--- a/app/controllers/episode_media_controller.rb
+++ b/app/controllers/episode_media_controller.rb
@@ -67,6 +67,8 @@ def episode_params
       :lock_version,
       :medium,
       :ad_breaks,
+      :enclosure_override_url,
+      :enclosure_override_prefix,
       contents_attributes: %i[id position original_url file_size _destroy _retry],
       uncut_attributes: %i[id segmentation original_url file_size _destroy _retry]
     )
diff --git a/app/helpers/episodes_helper.rb b/app/helpers/episodes_helper.rb
index 69ac00c2a..da2aa6e90 100644
--- a/app/helpers/episodes_helper.rb
+++ b/app/helpers/episodes_helper.rb
@@ -54,9 +54,9 @@ def episode_status_class(episode)
   def episode_media_status(episode)
     if episode_all_media(episode).any? { |m| upload_problem?(m) }
       "error"
-    elsif episode_all_media(episode).any? { |m| upload_processing?(m) }
+    elsif episode_all_media(episode).any? { |m| upload_processing?(m) } || episode.override_processing?
       "processing"
-    elsif episode.media_ready?(true)
+    elsif episode.media_ready?(true) || episode.override_ready?
       "complete"
     elsif episode.published_at.present?
       "incomplete-published"
diff --git a/app/models/concerns/episode_media.rb b/app/models/concerns/episode_media.rb
index f4cb94609..494b5bb79 100644
--- a/app/models/concerns/episode_media.rb
+++ b/app/models/concerns/episode_media.rb
@@ -4,14 +4,95 @@ module EpisodeMedia
   extend ActiveSupport::Concern
 
   included do
+    enum :medium, [:audio, :uncut, :video, :override], prefix: true
+
     # NOTE: this just-in-time creates new media versions
     # TODO: convert to sql, so we don't have to load/check every episode?
     # TODO: stop loading non-latest media versions
     scope :feed_ready, -> { includes(media_versions: :media_resources).select { |e| e.feed_ready? } }
+
+    has_many :media_versions, -> { order("created_at DESC") }, dependent: :destroy
+    has_many :contents, -> { order("position ASC, created_at DESC") }, autosave: true, dependent: :destroy, inverse_of: :episode
+    has_one :uncut, -> { order("created_at DESC") }, autosave: true, dependent: :destroy, inverse_of: :episode
+    has_one :external_media_resource, -> { order("created_at DESC") }, autosave: true, dependent: :destroy, inverse_of: :episode
+
+    accepts_nested_attributes_for :contents, allow_destroy: true, reject_if: ->(c) { c[:id].blank? && c[:original_url].blank? }
+    accepts_nested_attributes_for :uncut, allow_destroy: true, reject_if: ->(u) { u[:id].blank? && u[:original_url].blank? }
+
+    validate :validate_media_ready, if: :strict_validations
+
+    after_save :destroy_out_of_range_contents, if: ->(e) { e.segment_count_previously_changed? }
+    after_save :analyze_external_media
+  end
+
+  def validate_media_ready
+    return unless published_at.present? && media?
+
+    # media must be complete on _initial_ publish
+    # otherwise - having files in any status is good enough
+    is_ready =
+      if published_at_was.blank?
+        media_ready?(true) || override_ready?
+      elsif medium_uncut?
+        uncut.present? && !uncut.marked_for_destruction?
+      elsif override?
+        external_media_ready?
+      else
+        media_ready?(false)
+      end
+
+    unless is_ready
+      errors.add(:base, :media_not_ready, message: "media not ready")
+    end
+  end
+
+  def medium=(new_medium)
+    super
+
+    if medium_changed? && medium_was.present?
+      if medium_was == "uncut" && medium == "audio"
+        uncut&.mark_for_destruction
+      elsif medium_was == "audio" && medium == "uncut"
+        if (c = contents.first)
+          build_uncut.tap do |u|
+            u.file_size = contents.first.file_size
+            u.duration = contents.first.duration
+
+            # use the feeder cdn url for older completed files
+            is_old = (Time.now - c.created_at) > 24.hours
+            u.original_url = (c.status_complete? && is_old) ? c.url : c.original_url
+          end
+        end
+        contents.each(&:mark_for_destruction)
+      else
+        contents.each(&:mark_for_destruction)
+      end
+    end
+
+    self.segment_count = 1 if medium_video? || medium_override?
+  end
+
+  def copy_media(force = false)
+    contents.each { |c| c.copy_media(force) }
+    images.each { |i| i.copy_media(force) }
+    transcript&.copy_media(force)
+    uncut&.copy_media(force)
+  end
+
+  def build_contents
+    segment_range.map do |p|
+      contents.find { |c| c.position == p } || contents.build(position: p)
+    end
+  end
+
+  def destroy_out_of_range_contents
+    if segment_count.present? && segment_count.positive?
+      contents.where.not(position: segment_range.to_a).destroy_all
+    end
   end
 
   def feed_ready?
-    !media? || complete_media?
+    !media? || complete_media? || override_ready?
   end
 
   def cut_media_version!
@@ -97,7 +178,9 @@ def media_content_type(feed = nil)
     feed_content_type = feed.try(:mime_type)
 
     # if audio AND feed has a mime type, dovetail will transcode to that
-    if (media_content_type || "").starts_with?("audio")
+    if override?
+      external_media_resource&.mime_type || "audio/mpeg"
+    elsif (media_content_type || "").starts_with?("audio")
       feed_content_type || media_content_type
     elsif media_content_type
       media_content_type
@@ -111,11 +194,19 @@ def video_content_type?(*args)
   end
 
   def media_duration
-    media.inject(0.0) { |s, c| s + c.duration.to_f } + podcast.try(:duration_padding).to_f
+    if override?
+      external_media_resource&.duration
+    else
+      media.inject(0.0) { |s, c| s + c.duration.to_f } + podcast.try(:duration_padding).to_f
+    end
   end
 
   def media_file_size
-    media.inject(0) { |s, c| s + c.file_size.to_i }
+    if override?
+      external_media_resource&.file_size
+    else
+      media.inject(0) { |s, c| s + c.file_size.to_i }
+    end
   end
 
   def media_ready?(must_be_complete = true)
@@ -131,14 +222,18 @@ def media_ready?(must_be_complete = true)
   end
 
   def media_status
-    states = media.map(&:status).uniq
+    states = if override?
+      [external_media_resource&.status]
+    else
+      media.map(&:status).uniq
+    end
     if !(%w[started created processing retrying] & states).empty?
       "processing"
     elsif states.any? { |s| s == "error" }
       "error"
     elsif states.any? { |s| s == "invalid" }
       "invalid"
-    elsif media_ready?
+    elsif media_ready? || override_ready?
       "complete"
     end
   end
@@ -146,4 +241,29 @@ def media_status
   def media_url
     media.first.try(:href)
   end
+
+  def override_ready?
+    override? && external_media_ready?
+  end
+
+  def override_processing?
+    override? && !external_media_ready?
+  end
+
+  def override?
+    medium_override? || !enclosure_override_url.blank?
+  end
+
+  def external_media_ready?
+    external_media_resource&.status_complete?
+  end
+
+  def analyze_external_media
+    if enclosure_override_url.blank?
+      external_media_resource&.destroy
+    elsif enclosure_override_url != external_media_resource&.original_url
+      external_media_resource&.destroy
+      create_external_media_resource(original_url: enclosure_override_url)
+    end
+  end
 end
diff --git a/app/models/episode.rb b/app/models/episode.rb
index 36e9826e1..69ffa909a 100644
--- a/app/models/episode.rb
+++ b/app/models/episode.rb
@@ -23,22 +23,15 @@ class Episode < ApplicationRecord
 
   acts_as_paranoid
 
-  serialize :overrides, coder: HashSerializer
-
   belongs_to :podcast, -> { with_deleted }, touch: true
 
   has_many :episode_imports
-  has_many :contents, -> { order("position ASC, created_at DESC") }, autosave: true, dependent: :destroy, inverse_of: :episode
-  has_many :media_versions, -> { order("created_at DESC") }, dependent: :destroy
   has_many :images, -> { order("created_at DESC") }, class_name: "EpisodeImage", autosave: true, dependent: :destroy, inverse_of: :episode
 
   has_one :ready_image, -> { complete_or_replaced.order("created_at DESC") }, class_name: "EpisodeImage"
-  has_one :uncut, -> { order("created_at DESC") }, autosave: true, dependent: :destroy, inverse_of: :episode
   has_one :transcript, -> { order("created_at DESC") }, dependent: :destroy, inverse_of: :episode
 
-  accepts_nested_attributes_for :contents, allow_destroy: true, reject_if: ->(c) { c[:id].blank? && c[:original_url].blank? }
   accepts_nested_attributes_for :images, allow_destroy: true, reject_if: ->(i) { i[:id].blank? && i[:original_url].blank? }
-  accepts_nested_attributes_for :uncut, allow_destroy: true, reject_if: ->(u) { u[:id].blank? && u[:original_url].blank? }
   accepts_nested_attributes_for :transcript, allow_destroy: true, reject_if: ->(t) { t[:id].blank? && t[:original_url].blank? }
 
   validates :podcast_id, :guid, presence: true
@@ -53,12 +46,10 @@ class Episode < ApplicationRecord
   validates :explicit, inclusion: {in: %w[true false]}, allow_nil: true
   validates :segment_count, presence: true, if: :strict_validations
   validates :segment_count, numericality: {only_integer: true, greater_than: 0, less_than_or_equal_to: MAX_SEGMENT_COUNT}, allow_nil: true
-  validate :validate_media_ready, if: :strict_validations
 
   before_validation :set_defaults, :set_external_keyword, :sanitize_text
 
   after_save :publish_updated, if: ->(e) { e.published_at_previously_changed? }
-  after_save :destroy_out_of_range_contents, if: ->(e) { e.segment_count_previously_changed? }
 
   scope :published, -> { where("episodes.published_at IS NOT NULL AND episodes.published_at <= now()") }
   scope :published_by, ->(offset) { where("episodes.published_at IS NOT NULL AND episodes.published_at <= ?", Time.now - offset) }
@@ -71,8 +62,6 @@ class Episode < ApplicationRecord
   scope :dropdate_asc, -> { reorder(Arel.sql("#{DROP_DATE} ASC NULLS FIRST")) }
   scope :dropdate_desc, -> { reorder(Arel.sql("#{DROP_DATE} DESC NULLS LAST")) }
 
-  enum :medium, [:audio, :uncut, :video], prefix: true
-
   alias_attribute :number, :episode_number
   alias_attribute :season, :season_number
 
@@ -198,36 +187,6 @@ def url_was
     super || embed_player_landing_url(podcast, self)
   end
 
-  def medium=(new_medium)
-    super
-
-    if medium_changed? && medium_was.present?
-      if medium_was == "uncut" && medium == "audio"
-        uncut&.mark_for_destruction
-      elsif medium_was == "audio" && medium == "uncut"
-        if (c = contents.first)
-          build_uncut.tap do |u|
-            u.file_size = contents.first.file_size
-            u.duration = contents.first.duration
-
-            # use the feeder cdn url for older completed files
-            is_old = (Time.now - c.created_at) > 24.hours
-            u.original_url = (c.status_complete? && is_old) ? c.url : c.original_url
-          end
-        end
-        contents.each(&:mark_for_destruction)
-      else
-        contents.each(&:mark_for_destruction)
-      end
-    end
-
-    self.segment_count = 1 if medium_video?
-  end
-
-  def overrides
-    self[:overrides] ||= HashWithIndifferentAccess.new
-  end
-
   def categories
     self[:categories] || []
   end
@@ -236,13 +195,6 @@ def categories=(cats)
     self[:categories] = sanitize_categories(cats, false).presence
   end
 
-  def copy_media(force = false)
-    contents.each { |c| c.copy_media(force) }
-    images.each { |i| i.copy_media(force) }
-    transcript&.copy_media(force)
-    uncut&.copy_media(force)
-  end
-
   def publish!
     Rails.logger.tagged("Episode#publish!") do
       apple_mark_for_reupload!
@@ -306,18 +258,6 @@ def segment_range
     1..segment_count.to_i
   end
 
-  def build_contents
-    segment_range.map do |p|
-      contents.find { |c| c.position == p } || contents.build(position: p)
-    end
-  end
-
-  def destroy_out_of_range_contents
-    if segment_count.present? && segment_count.positive?
-      contents.where.not(position: segment_range.to_a).destroy_all
-    end
-  end
-
   def published_or_released_date
     if published_at.present?
       published_at
@@ -326,25 +266,6 @@ def published_or_released_date
     end
   end
 
-  def validate_media_ready
-    return unless published_at.present? && media?
-
-    # media must be complete on _initial_ publish
-    # otherwise - having files in any status is good enough
-    is_ready =
-      if published_at_was.blank?
-        media_ready?(true)
-      elsif medium_uncut?
-        uncut.present? && !uncut.marked_for_destruction?
-      else
-        media_ready?(false)
-      end
-
-    unless is_ready
-      errors.add(:base, :media_not_ready, message: "media not ready")
-    end
-  end
-
   def ready_transcript
     transcript if transcript&.status_complete?
   end
diff --git a/app/models/external_media_resource.rb b/app/models/external_media_resource.rb
new file mode 100644
index 000000000..f3a887b0b
--- /dev/null
+++ b/app/models/external_media_resource.rb
@@ -0,0 +1,34 @@
+class ExternalMediaResource < MediaResource
+  validates :duration, numericality: {greater_than: 0}, if: :status_complete?
+  after_create_commit :analyze_media
+
+  def guid
+    self[:guid]
+  end
+
+  def url
+    original_url
+  end
+
+  def media_url
+    original_url
+  end
+
+  def copy_media(force = false)
+  end
+
+  def analyze_media(force = false)
+    if force || !(status_complete? || task)
+      Tasks::AnalyzeMediaTask.create! do |task|
+        task.owner = self
+      end.start!
+    end
+  end
+
+  def retry!
+    if retryable?
+      status_retrying!
+      analyze_media(true)
+    end
+  end
+end
diff --git a/app/models/tasks/analyze_media_task.rb b/app/models/tasks/analyze_media_task.rb
new file mode 100644
index 000000000..f14d946f5
--- /dev/null
+++ b/app/models/tasks/analyze_media_task.rb
@@ -0,0 +1,43 @@
+class Tasks::AnalyzeMediaTask < ::Task
+  before_save :update_media_resource, if: ->(t) { t.status_changed? && t.media_resource }
+
+  def media_resource
+    owner
+  end
+
+  def source_url
+    media_resource.original_url
+  end
+
+  def porter_tasks
+    [{Type: "Inspect"}]
+  end
+
+  def update_media_resource
+    media_resource.status = status
+
+    if complete?
+      info = porter_callback_inspect
+      media_resource.mime_type = porter_callback_mime
+      media_resource.medium = (media_resource.mime_type || "").split("/").first
+      media_resource.file_size = porter_callback_size
+
+      if info[:Audio]
+        media_resource.sample_rate = info[:Audio][:Frequency].to_i
+        media_resource.channels = info[:Audio][:Channels].to_i
+        media_resource.duration = info[:Audio][:Duration].to_f / 1000
+        media_resource.bit_rate = info[:Audio][:Bitrate].to_i / 1000
+      end
+
+      # only return for actual videos - not detected images in id3 tags
+      if info[:Video] && media_resource.mime_type&.starts_with?("video")
+        media_resource.duration = info[:Video][:Duration].to_f / 1000
+        media_resource.width = info[:Video][:Width].to_i
+        media_resource.height = info[:Video][:Height].to_i
+        media_resource.frame_rate = info[:Video][:Framerate].to_f.round
+      end
+    end
+
+    media_resource.save!
+  end
+end
diff --git a/app/views/episode_media/_form.html.erb b/app/views/episode_media/_form.html.erb
index 9ad71d22e..316192e07 100644
--- a/app/views/episode_media/_form.html.erb
+++ b/app/views/episode_media/_form.html.erb
@@ -24,9 +24,25 @@
         <div class="col-lg-12">
           <% if episode.medium_uncut? %>
             <%= render "form_uncut", episode: episode, form: form %>
+          <% elsif episode.medium_override? %>
+            <%# no uploads for overrides %>
           <% else %>
             <%= render "form_contents", episode: episode, form: form %>
           <% end %>
+          <div class="col-12 mb-4">
+            <div class="form-floating input-group">
+              <%= form.text_field :enclosure_override_url %>
+              <%= form.label :enclosure_override_url, required: episode.medium_override? %>
+              <%= field_help_text t(".help.enclosure_override_url") %>
+            </div>
+            <div class="form-check">
+              <%= form.check_box :enclosure_override_prefix %>
+              <div class="d-flex align-items-center">
+                <%= form.label :enclosure_override_prefix %>
+                <%= help_text t(".help.enclosure_override_prefix") %>
+              </div>
+            </div>
+          </div>
         </div>
       </div>
     </div>
diff --git a/app/views/episode_media/_form_main.html.erb b/app/views/episode_media/_form_main.html.erb
index 87a463249..e48d85bc2 100644
--- a/app/views/episode_media/_form_main.html.erb
+++ b/app/views/episode_media/_form_main.html.erb
@@ -8,8 +8,7 @@
     <a hidden href="<%= request.fullpath %>" data-dynamic-form-target="link"></a>
   </div>
 </div>
-
-<% if episode.medium_video? %>
+<% if episode.medium_video? || episode.medium_override? %>
   <%= form.hidden_field :segment_count, value: 1 %>
 <% else %>
   <div class="col-12 mb-4">
diff --git a/app/views/episode_media/_form_status.html.erb b/app/views/episode_media/_form_status.html.erb
index 692900ad3..48265bac7 100644
--- a/app/views/episode_media/_form_status.html.erb
+++ b/app/views/episode_media/_form_status.html.erb
@@ -6,7 +6,7 @@
   <div class="card-footer">
     <div class="d-flex align-items-center justify-content-end">
       <button type="button"
-              class="btn btn-success me-2 <%= "d-none" if episode.medium_video? %>"
+              class="btn btn-success me-2 <%= "d-none" if (episode.medium_video? || episode.medium_override?) %>"
               data-bs-toggle="offcanvas"
               data-bs-target="#placements-preview-flyout"
               aria-controls="placements-preview-flyout"
diff --git a/app/views/episodes/_form_distribution.html.erb b/app/views/episodes/_form_distribution.html.erb
index 9040cca7d..02cf92a4d 100644
--- a/app/views/episodes/_form_distribution.html.erb
+++ b/app/views/episodes/_form_distribution.html.erb
@@ -22,7 +22,7 @@
 
     <div class="col-12 mb-4">
       <div class="form-floating input-group">
-        <% if episode.media_ready? %>
+        <% if episode.media_ready? || episode.override_ready? %>
           <%= form.text_field :enclosure_url, value: episode.enclosure_url, disabled: true %>
           <%= form.label :enclosure_url %>
           <%= field_copy episode.enclosure_url %>
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 027b740d4..ec36639c9 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -378,6 +378,7 @@ en:
           audio: Audio - upload multiple audio files
           uncut: Audio - upload a single file and then segment
           video: Video
+          override: Override - specify external media url
         original_guid: GUID
         released_at: Dropdate
         released_at_date: Date
diff --git a/test/models/episode_test.rb b/test/models/episode_test.rb
index 7b5be02e1..bfd850545 100644
--- a/test/models/episode_test.rb
+++ b/test/models/episode_test.rb
@@ -6,10 +6,9 @@
 
   let(:episode) { create(:episode_with_media) }
 
-  it "initializes guid and overrides" do
+  it "initializes guid" do
     e = Episode.new
     refute_nil e.guid
-    refute_nil e.overrides
   end
 
   it "sets updated_at when soft deleting episodes with no content" do
diff --git a/test/models/external_media_resource_test.rb b/test/models/external_media_resource_test.rb
new file mode 100644
index 000000000..b338ddfc4
--- /dev/null
+++ b/test/models/external_media_resource_test.rb
@@ -0,0 +1,7 @@
+require "test_helper"
+
+class ExternalMediaResourceTest < ActiveSupport::TestCase
+  # test "the truth" do
+  #   assert true
+  # end
+end

From 7e9482dd04105ed8d64d873fe690a955b46a8b94 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Tue, 10 Dec 2024 09:08:51 -0500
Subject: [PATCH 03/12] Lint fix

---
 app/views/episode_media/_form_status.html.erb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/views/episode_media/_form_status.html.erb b/app/views/episode_media/_form_status.html.erb
index 48265bac7..d408df514 100644
--- a/app/views/episode_media/_form_status.html.erb
+++ b/app/views/episode_media/_form_status.html.erb
@@ -6,7 +6,7 @@
   <div class="card-footer">
     <div class="d-flex align-items-center justify-content-end">
       <button type="button"
-              class="btn btn-success me-2 <%= "d-none" if (episode.medium_video? || episode.medium_override?) %>"
+              class="btn btn-success me-2 <%= "d-none" if episode.medium_video? || episode.medium_override? %>"
               data-bs-toggle="offcanvas"
               data-bs-target="#placements-preview-flyout"
               aria-controls="placements-preview-flyout"

From 46868123abc5500c5c21dfc21fef28fbd3ec14f8 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sat, 14 Dec 2024 13:55:01 -0500
Subject: [PATCH 04/12] Moving another method to episode_media

---
 app/models/concerns/episode_media.rb | 4 ++++
 app/models/episode.rb                | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/models/concerns/episode_media.rb b/app/models/concerns/episode_media.rb
index 494b5bb79..92e7152dc 100644
--- a/app/models/concerns/episode_media.rb
+++ b/app/models/concerns/episode_media.rb
@@ -79,6 +79,10 @@ def copy_media(force = false)
     uncut&.copy_media(force)
   end
 
+  def segment_range
+    1..segment_count.to_i
+  end
+
   def build_contents
     segment_range.map do |p|
       contents.find { |c| c.position == p } || contents.build(position: p)
diff --git a/app/models/episode.rb b/app/models/episode.rb
index 69ffa909a..a85b56e30 100644
--- a/app/models/episode.rb
+++ b/app/models/episode.rb
@@ -254,10 +254,6 @@ def feeder_cdn_host
     ENV["FEEDER_CDN_HOST"]
   end
 
-  def segment_range
-    1..segment_count.to_i
-  end
-
   def published_or_released_date
     if published_at.present?
       published_at

From ce9a4edfba4fd33a0dcf03cbd4135559f5679140 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sat, 14 Dec 2024 13:55:28 -0500
Subject: [PATCH 05/12] move tests to episode media too

---
 test/models/episode_test.rb | 108 ------------------------------------
 1 file changed, 108 deletions(-)

diff --git a/test/models/episode_test.rb b/test/models/episode_test.rb
index bfd850545..a98258e72 100644
--- a/test/models/episode_test.rb
+++ b/test/models/episode_test.rb
@@ -283,114 +283,6 @@
     end
   end
 
-  describe "#medium=" do
-    it "marks existing content for destruction on change" do
-      refute episode.contents.first.marked_for_destruction?
-
-      episode.medium = "audio"
-      refute episode.contents.first.marked_for_destruction?
-
-      episode.medium = "uncut"
-      assert episode.contents.first.marked_for_destruction?
-      assert episode.uncut.new_record?
-      assert_equal episode.contents.first.original_url, episode.uncut.original_url
-    end
-
-    it "sets segment count for videos" do
-      episode.segment_count = 2
-      refute episode.contents.first.marked_for_destruction?
-
-      episode.medium = "video"
-      assert episode.contents.first.marked_for_destruction?
-      assert_equal 1, episode.segment_count
-    end
-  end
-
-  describe "#segment_range" do
-    it "returns a range of positions" do
-      e = Episode.new(segment_count: nil)
-      assert_equal [], e.segment_range.to_a
-
-      e.segment_count = 1
-      assert_equal [1], e.segment_range.to_a
-
-      e.segment_count = 4
-      assert_equal [1, 2, 3, 4], e.segment_range.to_a
-    end
-  end
-
-  describe "#build_contents" do
-    it "builds contents for missing positions" do
-      e = Episode.new(segment_count: 3)
-      c1 = e.contents.build(position: 2)
-      _c2 = e.contents.build(position: 4)
-
-      built = e.build_contents
-      assert_equal 3, built.length
-      assert_equal 1, built[0].position
-      assert_equal c1, built[1]
-      assert_equal 3, built[2].position
-    end
-  end
-
-  describe "#destroy_out_of_range_contents" do
-    it "marks contents for destruction" do
-      c1 = episode.contents.create!(original_url: "c1", position: 2)
-      c2 = episode.contents.create!(original_url: "c2", position: 4)
-
-      episode.segment_count = nil
-      episode.destroy_out_of_range_contents
-      assert_nil c1.reload.deleted_at
-      assert_nil c2.reload.deleted_at
-
-      episode.segment_count = 3
-      episode.destroy_out_of_range_contents
-      assert_nil c1.reload.deleted_at
-      refute_nil c2.reload.deleted_at
-    end
-  end
-
-  describe "#validate_media_ready" do
-    it "only runs on strict + published episodes with media" do
-      e = build_stubbed(:episode, segment_count: 1)
-      assert e.valid?
-
-      e.strict_validations = true
-      refute e.valid?
-
-      e.published_at = nil
-      assert e.valid?
-    end
-
-    it "checks for complete media on initial publish" do
-      e = create(:episode_with_media, strict_validations: true, published_at: nil)
-      assert e.valid?
-
-      e.published_at = 1.hour.ago
-      assert e.valid?
-
-      e.contents.first.status = "invalid"
-      refute e.valid?
-      assert_includes e.errors[:base], "media not ready"
-    end
-
-    it "checks for present media on subsequent updates" do
-      e = create(:episode_with_media, strict_validations: true, published_at: 1.hour.ago)
-      assert e.valid?
-
-      e.contents.first.status = "processing"
-      assert e.valid?
-
-      # also applies to uncut media
-      e.medium = "uncut"
-      e.uncut = nil
-      refute e.valid?
-
-      e.uncut = build(:uncut)
-      assert e.valid?
-    end
-  end
-
   describe "#description_with_default" do
     let(:episode) { build_stubbed(:episode, description: "description", subtitle: "subtitle", title: "title") }
 

From ba82e6f047f64742517190dec07cff957ac99848 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sat, 14 Dec 2024 13:56:02 -0500
Subject: [PATCH 06/12] move tests from episode, add override tests

---
 test/models/concerns/episode_media_test.rb | 180 +++++++++++++++++++++
 1 file changed, 180 insertions(+)

diff --git a/test/models/concerns/episode_media_test.rb b/test/models/concerns/episode_media_test.rb
index f47edda27..88828cac7 100644
--- a/test/models/concerns/episode_media_test.rb
+++ b/test/models/concerns/episode_media_test.rb
@@ -5,6 +5,118 @@ class EpisodeMediaTest < ActiveSupport::TestCase
   let(:c2) { build_stubbed(:content, status: "complete", position: 2) }
   let(:ep) { build(:episode, segment_count: 2, contents: [c1, c2]) }
 
+  describe "#validate_media_ready" do
+    it "only runs on strict + published episodes with media" do
+      e = build_stubbed(:episode, segment_count: 1)
+      assert e.valid?
+
+      e.strict_validations = true
+      refute e.valid?
+
+      e.published_at = nil
+      assert e.valid?
+    end
+
+    it "checks for complete media on initial publish" do
+      e = create(:episode_with_media, strict_validations: true, published_at: nil)
+      assert e.valid?
+
+      e.published_at = 1.hour.ago
+      assert e.valid?
+
+      e.contents.first.status = "invalid"
+      refute e.valid?
+      assert_includes e.errors[:base], "media not ready"
+    end
+
+    it "checks for present media on subsequent updates" do
+      e = create(:episode_with_media, strict_validations: true, published_at: 1.hour.ago)
+      assert e.valid?
+
+      e.contents.first.status = "processing"
+      assert e.valid?
+
+      # also applies to uncut media
+      e.medium = "uncut"
+      e.uncut = nil
+      refute e.valid?
+
+      e.uncut = build(:uncut)
+      assert e.valid?
+    end
+  end
+
+  describe "#medium=" do
+    let(:episode) { create(:episode_with_media) }
+
+    it "marks existing content for destruction on change" do
+      refute episode.contents.first.marked_for_destruction?
+
+      episode.medium = "audio"
+      refute episode.contents.first.marked_for_destruction?
+
+      episode.medium = "uncut"
+      assert episode.contents.first.marked_for_destruction?
+      assert episode.uncut.new_record?
+      assert_equal episode.contents.first.original_url, episode.uncut.original_url
+    end
+
+    it "sets segment count for videos" do
+      episode.segment_count = 2
+      refute episode.contents.first.marked_for_destruction?
+
+      episode.medium = "video"
+      assert episode.contents.first.marked_for_destruction?
+      assert_equal 1, episode.segment_count
+    end
+  end
+
+  describe "#segment_range" do
+    it "returns a range of positions" do
+      e = Episode.new(segment_count: nil)
+      assert_equal [], e.segment_range.to_a
+
+      e.segment_count = 1
+      assert_equal [1], e.segment_range.to_a
+
+      e.segment_count = 4
+      assert_equal [1, 2, 3, 4], e.segment_range.to_a
+    end
+  end
+
+  describe "#build_contents" do
+    it "builds contents for missing positions" do
+      e = Episode.new(segment_count: 3)
+      c1 = e.contents.build(position: 2)
+      _c2 = e.contents.build(position: 4)
+
+      built = e.build_contents
+      assert_equal 3, built.length
+      assert_equal 1, built[0].position
+      assert_equal c1, built[1]
+      assert_equal 3, built[2].position
+    end
+  end
+
+  describe "#destroy_out_of_range_contents" do
+    let(:episode) { create(:episode_with_media) }
+
+    it "marks contents for destruction" do
+      c1 = episode.contents.create!(original_url: "c1", position: 2)
+      c2 = episode.contents.create!(original_url: "c2", position: 4)
+
+      episode.segment_count = nil
+      episode.destroy_out_of_range_contents
+      assert_nil c1.reload.deleted_at
+      assert_nil c2.reload.deleted_at
+
+      episode.segment_count = 3
+      episode.destroy_out_of_range_contents
+      assert_nil c1.reload.deleted_at
+      refute_nil c2.reload.deleted_at
+    end
+  end
+
   describe ".feed_ready" do
     it "just in time creates new media versions" do
       episode = create(:episode, segment_count: 2)
@@ -33,6 +145,74 @@ class EpisodeMediaTest < ActiveSupport::TestCase
     end
   end
 
+  describe "overrides media attributes" do
+    it "mark as ready for external media complete" do
+      episode = build_stubbed(:episode, medium: :audio, segment_count: nil)
+      url = "https://prx.org/a.mp3"
+      episode.stub(:complete_media, []) do
+        refute episode.override?
+        refute episode.feed_ready?
+
+        episode.medium = :override
+        episode.enclosure_override_url = :nil
+        assert episode.override?
+        refute episode.feed_ready?
+
+        episode.medium = :audio
+        episode.enclosure_override_url = url
+        assert episode.override?
+        refute episode.override_ready?
+        refute episode.external_media_ready?
+        refute episode.feed_ready?
+
+        episode.build_external_media_resource(status: "processing", original_url: url)
+        assert episode.override_processing?
+        refute episode.override_ready?
+        refute episode.external_media_ready?
+        refute episode.feed_ready?
+
+        episode.build_external_media_resource(status: "complete", original_url: url)
+        refute episode.override_processing?
+        assert episode.override_ready?
+        assert episode.external_media_ready?
+        assert episode.feed_ready?
+      end
+    end
+
+    it "overrides media content type" do
+      c1.mime_type = "some/thing1"
+      assert_equal "some/thing1", ep.media_content_type
+
+      ep.enclosure_override_url = "https://prx.org/a.mp3"
+      ep.build_external_media_resource(status: "complete", mime_type: "some/thing2")
+      assert_equal "some/thing2", ep.media_content_type
+    end
+
+    it "overrides media content type" do
+      assert_equal 96.00, ep.media_duration
+
+      ep.enclosure_override_url = "https://prx.org/a.mp3"
+      ep.build_external_media_resource(status: "complete", duration: 240)
+      assert_equal 240.00, ep.media_duration
+    end
+
+    it "overrides media file size" do
+      assert_equal 1548118, ep.media_file_size
+
+      ep.enclosure_override_url = "https://prx.org/a.mp3"
+      ep.build_external_media_resource(status: "complete", file_size: 2222222)
+      assert_equal 2222222, ep.media_file_size
+    end
+
+    it "overrides media status" do
+      assert_equal "complete", ep.media_status
+
+      ep.enclosure_override_url = "https://prx.org/a.mp3"
+      ep.build_external_media_resource(status: "processing")
+      assert_equal "processing", ep.media_status
+    end
+  end
+
   describe "#cut_media_version!" do
     it "creates new media versions" do
       episode = create(:episode, segment_count: 2)

From 064c6ff55b227a4133bf78d3f4f3023e30a6adff Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sat, 14 Dec 2024 13:56:48 -0500
Subject: [PATCH 07/12] Add test for setting enclosure override

---
 test/controllers/episode_media_controller_test.rb | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/test/controllers/episode_media_controller_test.rb b/test/controllers/episode_media_controller_test.rb
index 59de6881e..b20754f04 100644
--- a/test/controllers/episode_media_controller_test.rb
+++ b/test/controllers/episode_media_controller_test.rb
@@ -1,6 +1,6 @@
 require "test_helper"
 
-class EpisodeSegmenterControllerTest < ActionDispatch::IntegrationTest
+class EpisodeMediaControllerTest < ActionDispatch::IntegrationTest
   let(:podcast) { create(:podcast, prx_account_uri: "/api/v1/accounts/123") }
   let(:episode) { create(:episode, podcast: podcast, segment_count: 1, published_at: nil) }
   let(:params) { {ad_breaks: 2} }
@@ -43,6 +43,18 @@ class EpisodeSegmenterControllerTest < ActionDispatch::IntegrationTest
     end
   end
 
+  test "analyzes external media" do
+    assert_nil episode.reload.enclosure_override_url
+    assert_nil episode.external_media_resource
+
+    ExternalMediaResource.stub_any_instance(:analyze_media, true) do
+      patch episode_media_path(episode), params: {episode: {enclosure_override_url: "https://prx.org/a.mp3"}}
+      assert_redirected_to episode_media_path(episode)
+      assert_equal "https://prx.org/a.mp3", episode.reload.enclosure_override_url
+      assert_equal "https://prx.org/a.mp3", episode.external_media_resource.original_url
+    end
+  end
+
   test "authorizes updating episode media" do
     podcast.update(prx_account_uri: "/api/v1/accounts/456")
     patch episode_media_path(episode), params: {episode: params}

From 57a8701953f92259f5bb892119271225eb327c52 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sun, 15 Dec 2024 10:15:58 -0500
Subject: [PATCH 08/12] no copying no need for a guid

---
 app/models/external_media_resource.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/models/external_media_resource.rb b/app/models/external_media_resource.rb
index f3a887b0b..9359e7b84 100644
--- a/app/models/external_media_resource.rb
+++ b/app/models/external_media_resource.rb
@@ -3,7 +3,7 @@ class ExternalMediaResource < MediaResource
   after_create_commit :analyze_media
 
   def guid
-    self[:guid]
+    nil
   end
 
   def url

From 8d081657e1a48027a77f7a3da822e4634b9379fd Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sun, 15 Dec 2024 10:20:40 -0500
Subject: [PATCH 09/12] More complete tests

---
 test/factories/media_resource_factory.rb     |  4 ++
 test/factories/porter_callback_factory.rb    | 14 +++++
 test/factories/task_factory.rb               |  7 +++
 test/models/concerns/episode_media_test.rb   | 25 +++++++-
 test/models/external_media_resource_test.rb  | 34 ++++++++--
 test/models/tasks/analyze_media_task_test.rb | 66 ++++++++++++++++++++
 6 files changed, 145 insertions(+), 5 deletions(-)
 create mode 100644 test/models/tasks/analyze_media_task_test.rb

diff --git a/test/factories/media_resource_factory.rb b/test/factories/media_resource_factory.rb
index 9ad569277..eed884ac5 100644
--- a/test/factories/media_resource_factory.rb
+++ b/test/factories/media_resource_factory.rb
@@ -30,5 +30,9 @@
       segmentation { [[1.23, 4.56]] }
       task_count { 0 }
     end
+
+    factory :external_media_resource, class: ExternalMediaResource do
+      original_url { "https://prx.org/audio.mp3" }
+    end
   end
 end
diff --git a/test/factories/porter_callback_factory.rb b/test/factories/porter_callback_factory.rb
index 9392b4fb7..9829e9e8f 100644
--- a/test/factories/porter_callback_factory.rb
+++ b/test/factories/porter_callback_factory.rb
@@ -160,6 +160,20 @@
     initialize_with { attributes.with_indifferent_access }
   end
 
+  factory :porter_job_analyze_results, class: Hash do
+    Time { "2012-12-21T12:34:56Z" }
+    Timestamp { 1356093296.0 }
+    JobResult do
+      {
+        Job: {Id: "the-job-id"},
+        State: "DONE",
+        TaskResults: [build(:porter_inspect_audio_result)],
+        FailedTasks: []
+      }
+    end
+    initialize_with { attributes.with_indifferent_access }
+  end
+
   factory :porter_image_job_results, class: Hash do
     Time { "2012-12-21T12:34:56Z" }
     Timestamp { 1356093296.0 }
diff --git a/test/factories/task_factory.rb b/test/factories/task_factory.rb
index 10ce4a3b2..2366b1344 100644
--- a/test/factories/task_factory.rb
+++ b/test/factories/task_factory.rb
@@ -11,6 +11,13 @@
     end
   end
 
+  factory :analyze_media_task, class: Tasks::AnalyzeMediaTask do
+    association :owner, factory: :external_media_resource
+    status { :complete }
+    job_id { "1234" }
+    result { build(:porter_job_analyze_results) }
+  end
+
   factory :copy_image_task, class: Tasks::CopyImageTask do
     association :owner, factory: :episode_image_with_episode
     status { :complete }
diff --git a/test/models/concerns/episode_media_test.rb b/test/models/concerns/episode_media_test.rb
index 88828cac7..689c3cc52 100644
--- a/test/models/concerns/episode_media_test.rb
+++ b/test/models/concerns/episode_media_test.rb
@@ -154,7 +154,7 @@ class EpisodeMediaTest < ActiveSupport::TestCase
         refute episode.feed_ready?
 
         episode.medium = :override
-        episode.enclosure_override_url = :nil
+        episode.enclosure_override_url = nil
         assert episode.override?
         refute episode.feed_ready?
 
@@ -179,6 +179,29 @@ class EpisodeMediaTest < ActiveSupport::TestCase
       end
     end
 
+    it "creates override media when override url set" do
+      episode = create(:episode, segment_count: 2)
+      assert_nil episode.external_media_resource
+      episode.enclosure_override_url = "https://prx.org/a.mp3"
+      ExternalMediaResource.stub_any_instance(:analyze_media, true) do
+        episode.save!
+      end
+      assert_equal episode.external_media_resource.original_url, "https://prx.org/a.mp3"
+    end
+
+    it "creates override media when override url updated" do
+      ExternalMediaResource.stub_any_instance(:analyze_media, true) do
+        episode = create(:episode, enclosure_override_url: "https://prx.org/a.mp3")
+        assert_equal episode.external_media_resource.original_url, "https://prx.org/a.mp3"
+        emr_id = episode.external_media_resource.id
+        episode.external_media_resource
+
+        episode.update(enclosure_override_url: "https://prx.org/new.mp3")
+        assert_equal episode.external_media_resource.original_url, "https://prx.org/new.mp3"
+        assert emr_id != episode.external_media_resource.id
+      end
+    end
+
     it "overrides media content type" do
       c1.mime_type = "some/thing1"
       assert_equal "some/thing1", ep.media_content_type
diff --git a/test/models/external_media_resource_test.rb b/test/models/external_media_resource_test.rb
index b338ddfc4..9d6411555 100644
--- a/test/models/external_media_resource_test.rb
+++ b/test/models/external_media_resource_test.rb
@@ -1,7 +1,33 @@
 require "test_helper"
 
-class ExternalMediaResourceTest < ActiveSupport::TestCase
-  # test "the truth" do
-  #   assert true
-  # end
+describe ExternalMediaResource do
+  let(:episode) { create(:episode, external_media_resource: media, enclosure_override_url: media.original_url) }
+  let(:media) { build(:external_media_resource) }
+
+  describe "#validate_episode_medium" do
+    it "does not have a guid" do
+      assert_nil media.guid
+    end
+
+    it "urls are the same as original" do
+      assert_equal media.url, media.original_url
+      assert_equal media.media_url, media.original_url
+    end
+
+    it "doesn't copy external media" do
+      # copy is a no-op
+      refute media.copy_media
+    end
+
+    it "analyzes the external media" do
+      Tasks::AnalyzeMediaTask.stub_any_instance(:porter_start!, true) do
+        media.analyze_media
+        media.reload
+        task = media.task
+        assert task.is_a?(Tasks::AnalyzeMediaTask)
+        assert_equal task.options["Source"]["URL"], "https://prx.org/audio.mp3"
+        assert_equal task.options["Tasks"].first["Type"], "Inspect"
+      end
+    end
+  end
 end
diff --git a/test/models/tasks/analyze_media_task_test.rb b/test/models/tasks/analyze_media_task_test.rb
new file mode 100644
index 000000000..a7ee252e9
--- /dev/null
+++ b/test/models/tasks/analyze_media_task_test.rb
@@ -0,0 +1,66 @@
+require "test_helper"
+
+describe Tasks::AnalyzeMediaTask do
+  let(:task) { build_stubbed(:analyze_media_task) }
+
+  describe "#source_url" do
+    it "is the media resource href" do
+      task.media_resource.stub(:original_url, "whatev") do
+        assert_equal "whatev", task.source_url
+      end
+    end
+  end
+
+  describe "#porter_tasks" do
+    it "runs an inspect task" do
+      assert_equal "Inspect", task.porter_tasks[0][:Type]
+    end
+  end
+
+  describe "#update_media_resource" do
+    let(:task) { create(:copy_media_task) }
+
+    it "updates status before save" do
+      assert_equal task.status, "complete"
+      assert_equal task.media_resource.status, "complete"
+      task.update(status: "processing")
+      assert_equal task.status, "processing"
+      assert_equal task.media_resource.status, "processing"
+    end
+
+    it "replaces resources and publishes on complete" do
+      publish = Minitest::Mock.new
+
+      task.media_resource.episode.stub(:publish!, publish) do
+        task.update(status: "created")
+        assert publish.verify
+
+        publish.expect(:call, nil)
+        task.update(status: "complete")
+        assert publish.verify
+      end
+    end
+
+    it "updates audio metadata on complete" do
+      task.media_resource.reset_media_attributes
+
+      task.update(status: "created")
+      assert_nil task.media_resource.mime_type
+
+      task.update(status: "complete")
+      assert_equal 192, task.media_resource.bit_rate
+      assert_equal 2, task.media_resource.channels
+      assert_equal 1371.437, task.media_resource.duration
+      assert_equal 32980032, task.media_resource.file_size
+      assert_equal "audio", task.media_resource.medium
+      assert_equal "audio/mpeg", task.media_resource.mime_type
+      assert_equal 48000, task.media_resource.sample_rate
+
+      # this audio has a video stream (the ID3 image) - but we should
+      # not be parsing the metadata for it
+      assert_nil task.media_resource.frame_rate
+      assert_nil task.media_resource.height
+      assert_nil task.media_resource.width
+    end
+  end
+end

From 5ce0beb9cd59e0e83d95a4f40733707fb9a79bf6 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Thu, 9 Jan 2025 00:29:21 -0500
Subject: [PATCH 10/12] Shift to copy_media like other media resource types

---
 app/models/concerns/episode_media.rb        | 1 +
 app/models/external_media_resource.rb       | 9 +--------
 test/models/external_media_resource_test.rb | 5 -----
 3 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/app/models/concerns/episode_media.rb b/app/models/concerns/episode_media.rb
index 92e7152dc..c7d60cf4d 100644
--- a/app/models/concerns/episode_media.rb
+++ b/app/models/concerns/episode_media.rb
@@ -77,6 +77,7 @@ def copy_media(force = false)
     images.each { |i| i.copy_media(force) }
     transcript&.copy_media(force)
     uncut&.copy_media(force)
+    external_media_resource&.copy_media(force)
   end
 
   def segment_range
diff --git a/app/models/external_media_resource.rb b/app/models/external_media_resource.rb
index 9359e7b84..eb55b465b 100644
--- a/app/models/external_media_resource.rb
+++ b/app/models/external_media_resource.rb
@@ -1,6 +1,5 @@
 class ExternalMediaResource < MediaResource
   validates :duration, numericality: {greater_than: 0}, if: :status_complete?
-  after_create_commit :analyze_media
 
   def guid
     nil
@@ -15,6 +14,7 @@ def media_url
   end
 
   def copy_media(force = false)
+    analyze_media(force)
   end
 
   def analyze_media(force = false)
@@ -24,11 +24,4 @@ def analyze_media(force = false)
       end.start!
     end
   end
-
-  def retry!
-    if retryable?
-      status_retrying!
-      analyze_media(true)
-    end
-  end
 end
diff --git a/test/models/external_media_resource_test.rb b/test/models/external_media_resource_test.rb
index 9d6411555..3877faa8b 100644
--- a/test/models/external_media_resource_test.rb
+++ b/test/models/external_media_resource_test.rb
@@ -14,11 +14,6 @@
       assert_equal media.media_url, media.original_url
     end
 
-    it "doesn't copy external media" do
-      # copy is a no-op
-      refute media.copy_media
-    end
-
     it "analyzes the external media" do
       Tasks::AnalyzeMediaTask.stub_any_instance(:porter_start!, true) do
         media.analyze_media

From 7bd2e5ab85e3822ebee46e6a899d1b63dd7a22c9 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sat, 11 Jan 2025 12:07:42 -0500
Subject: [PATCH 11/12] Handle override not yet processed for published episode
 save

---
 app/models/concerns/episode_media.rb | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/app/models/concerns/episode_media.rb b/app/models/concerns/episode_media.rb
index c7d60cf4d..0a2291918 100644
--- a/app/models/concerns/episode_media.rb
+++ b/app/models/concerns/episode_media.rb
@@ -32,13 +32,11 @@ def validate_media_ready
     # otherwise - having files in any status is good enough
     is_ready =
       if published_at_was.blank?
-        media_ready?(true) || override_ready?
+        media_ready?(true) || override_ready?(true)
       elsif medium_uncut?
         uncut.present? && !uncut.marked_for_destruction?
-      elsif override?
-        external_media_ready?
       else
-        media_ready?(false)
+        media_ready?(false) || override_ready?(false)
       end
 
     unless is_ready
@@ -247,8 +245,8 @@ def media_url
     media.first.try(:href)
   end
 
-  def override_ready?
-    override? && external_media_ready?
+  def override_ready?(must_be_complete = true)
+    override? && external_media_ready?(must_be_complete)
   end
 
   def override_processing?
@@ -259,8 +257,12 @@ def override?
     medium_override? || !enclosure_override_url.blank?
   end
 
-  def external_media_ready?
-    external_media_resource&.status_complete?
+  def external_media_ready?(must_be_complete = true)
+    if must_be_complete
+      external_media_resource&.status_complete?
+    else
+      external_media_resource.present?
+    end
   end
 
   def analyze_external_media

From 777e876130fcdcbf89c9ea6b3f9a2ed9b9c74ae9 Mon Sep 17 00:00:00 2001
From: Andrew Kuklewicz <andrew@beginsinwonder.com>
Date: Sat, 11 Jan 2025 12:08:16 -0500
Subject: [PATCH 12/12] Add a comment to clarify where media associations went

---
 app/models/episode.rb | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/models/episode.rb b/app/models/episode.rb
index a85b56e30..6c8024c44 100644
--- a/app/models/episode.rb
+++ b/app/models/episode.rb
@@ -25,6 +25,12 @@ class Episode < ApplicationRecord
 
   belongs_to :podcast, -> { with_deleted }, touch: true
 
+  # See concerns/episode_media.rb for media/audio related code, e.g. the associations
+  # has_many :media_versions ...
+  # has_many :contents ...
+  # has_one :uncut ...
+  # has_one :external_media_resource ...
+
   has_many :episode_imports
   has_many :images, -> { order("created_at DESC") }, class_name: "EpisodeImage", autosave: true, dependent: :destroy, inverse_of: :episode