-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update threads_per_worker in example run script #926
Comments
Thanks for opening this issue. I agree it looks like this is the right call, but I was going to ask you both to try a run with this setting on your Macs to make sure there is no regression on your side. I don't have a good sense of the default features of the Dask https://github.com/PSLmodels/OG-USA/blob/master/cs-config/cs_config/functions.py#L214 Can you provide some details on what |
@talumbau asks:
the
Ok - let me know what these means. We thought it was pretty useful that the client passes through the OG-Core model and so one can set that up in the "run script" for whatever their configuration is (e.g., running on a local cluster, a cluster with Slurm scheduler, etc.). But anything that would aid users parameterizing the client correctly for their environment would be good. |
The updating of the run script threads-per-worker part of this issue was resolved in PR #928. However, it looks like we still need to resolve how Dask clusters are created in the Compute Studio files. |
There should be no CS file in this repo. |
@talumbau and @jdebacker. I think we need to make the same change in the OG-Core example run script that TJ's PR #102 made in OG-USA. We should limit the number of
threads_per_worker
to 1 in the daskClient
class instantiation.The text was updated successfully, but these errors were encountered: