Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not report "## devices connected" in heartbeat() #13

Open
brendanmatkin opened this issue Sep 17, 2018 · 0 comments
Open

do not report "## devices connected" in heartbeat() #13

brendanmatkin opened this issue Sep 17, 2018 · 0 comments
Labels
bug Something isn't working ConfigApp Related to the configuration app/server

Comments

@brendanmatkin
Copy link
Collaborator

call a function on interval that checks if wss.clients.size has changes and report.

Currently this happens in heartbeat - this can NEVER reach zero because if zero devices are connected then you will never get a pong and heartbeat won't be called!
@brendanmatkin brendanmatkin added bug Something isn't working ConfigApp Related to the configuration app/server labels Sep 17, 2018
@brendanmatkin brendanmatkin mentioned this issue Sep 17, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ConfigApp Related to the configuration app/server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brendanmatkin