Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator: Land: Improve it for VTOL by taking breaking distance into account #23566

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

Claudio-Chies
Copy link
Contributor

@Claudio-Chies Claudio-Chies commented Aug 19, 2024

Solved Problem

When triggering a Land on a VTOL, the horizontal speed might not be zero after the back transition, resulting in a weird flying back movement, which comes from the fact that the setpoint is only updated until the transition is done, and not until it has come to a stop.

Solution

I propose we adapt the target landing location location setpoint based on the current velocity, and possible acceleration and jerk in MC mode.

Changelog Entry

Bugfix: VTOL Landing Location
Documentation: Landing location for VTOL is where it came to an full halt, and not where backtransition was completed.

Test coverage

Tested in SITL & on Hardware

@Claudio-Chies Claudio-Chies added the Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing! label Aug 19, 2024
@Claudio-Chies Claudio-Chies requested a review from sfuhrer August 19, 2024 07:07
@Jaeyoung-Lim
Copy link
Member

Jaeyoung-Lim commented Aug 19, 2024

I can confirm that this caused quite hairy situations when flying our VTOL, (rapid loss of altitude after transitions)

@sfuhrer sfuhrer changed the title VTOL, adjust landing setpoint Navigator: Land: Improve if for VTOL by taking breaking distance into account Aug 19, 2024
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right solution to me. Let's though first test if on real hardware before merging.

src/modules/navigator/land.cpp Outdated Show resolved Hide resolved
@sfuhrer sfuhrer changed the title Navigator: Land: Improve if for VTOL by taking breaking distance into account Navigator: Land: Improve it for VTOL by taking breaking distance into account Aug 19, 2024
Co-authored-by: Silvan Fuhrer <[email protected]>
@Claudio-Chies
Copy link
Contributor Author

Tested on Hardware, seems to work nicely
added flight log to PR above

Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfuhrer sfuhrer merged commit ee022a7 into main Aug 22, 2024
96 checks passed
@sfuhrer sfuhrer deleted the pr-vtol_landing branch August 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants