-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster than Real -Time support in GZ #23783
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: dirksavage88 <[email protected]>
@Jaeyoung-Lim @dagar can you please give this a review? seems like a good addition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing thanks!
-
Just one small nitpick on the order of configuring the physics.
-
More of a question/note: Since we configure the physics in the gz bridge, this might cause problems when running multiple px4 instances. Might be worth taking it out to somewhere else in the future.
if (!callPhysicsMsgService(physics_service, p_req)) { | ||
return PX4_ERROR; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably harmless, but should we maybe configure the physics before spawning the model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I placed the physics service call further up in the init method, but not sure if this is before the model spawn you mentioned @Jaeyoung-Lim
Signed-off-by: dirksavage88 <[email protected]>
This will good and will need docs hint hint |
Solved Problem
The new GZ simulation real time factor is configurable, however the service request has not been implemented in the GZ bridge.
partially fixes Fixes #23602
Solution
Changelog Entry
For release notes:
Alternatives
Change the real time facto in gazebo world sdf manually, or make a world file specific to an increased RTF
Test coverage
rtf.webm
Context
Related links, screenshot before/after, video