Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable PX4 SITL tests #23966

Closed
wants to merge 1 commit into from
Closed

ci: disable PX4 SITL tests #23966

wants to merge 1 commit into from

Conversation

mrpollo
Copy link
Contributor

@mrpollo mrpollo commented Nov 18, 2024

Disables flaky SITL tests.

See #23965

Copy link

FLASH Analysis

px4_fmu-v5x
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  +0.0%      +8    .text
  -0.0%      -8  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%      +8    TOTAL

px4_fmu-v6x
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  +0.0%      +8    .text
  -0.0%      -8  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%      +8    TOTAL

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given no one seems to care, I'm ok disabling them.

However, instead of commenting everything, I'd just rename the file to .yml.disabled.

@dagar
Copy link
Member

dagar commented Nov 19, 2024

Can't we disable the flaky tests within instead of the entire set?

@julianoes
Copy link
Contributor

Do we know which ones are flaky?

@mrpollo
Copy link
Contributor Author

mrpollo commented Nov 20, 2024

@mrpollo mrpollo force-pushed the mrpollo/disable_sitl_tests branch from f74bc7e to c9cf2b5 Compare November 20, 2024 16:35
Copy link

FLASH Analysis

px4_fmu-v5x
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  +0.0%      +8    .text
  -0.0%      -8  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%      +8    TOTAL

px4_fmu-v6x
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  +0.0%      +8    .text
  -0.0%      -8  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%      +8    TOTAL

@mrpollo
Copy link
Contributor Author

mrpollo commented Nov 20, 2024

We started fixing the tests #23995

@mrpollo mrpollo closed this Nov 20, 2024
@MaEtUgR MaEtUgR deleted the mrpollo/disable_sitl_tests branch November 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants