Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

EKF minimize console output #909

Open
dagar opened this issue Sep 21, 2020 · 2 comments
Open

EKF minimize console output #909

dagar opened this issue Sep 21, 2020 · 2 comments

Comments

@dagar
Copy link
Member

dagar commented Sep 21, 2020

Can we work on minimizing console output for the estimator? It gets a little absurd when running multiple instances of ecl/EKF (PX4/PX4-Autopilot#14650).

INFO  [ecl/EKF] reset position to last known position
INFO  [ecl/EKF] reset velocity to zero
INFO  [ecl/EKF] reset position to last known position
INFO  [ecl/EKF] reset velocity to zero
INFO  [ecl/EKF] reset position to last known position
INFO  [ecl/EKF] reset velocity to zero
INFO  [ecl/EKF] reset position to last known position
INFO  [ecl/EKF] reset velocity to zero
INFO  [ecl/EKF] reset position to last known position
INFO  [ecl/EKF] reset velocity to zero
INFO  [ecl/EKF] reset position to last known position
INFO  [ecl/EKF] reset velocity to zero
INFO  [ecl/EKF] 11544067: EKF aligned, (baro hgt, IMU buf: 18, OBS buf: 14)
INFO  [ecl/EKF] 11644085: EKF aligned, (baro hgt, IMU buf: 18, OBS buf: 14)
INFO  [ecl/EKF] 11751436: EKF aligned, (baro hgt, IMU buf: 18, OBS buf: 14)
INFO  [ecl/EKF] 11813268: EKF aligned, (baro hgt, IMU buf: 18, OBS buf: 14)
INFO  [ecl/EKF] 11951770: EKF aligned, (baro hgt, IMU buf: 18, OBS buf: 14)
INFO  [ecl/EKF] 11973531: EKF aligned, (baro hgt, IMU buf: 18, OBS buf: 14)

I would propose we (incrementally) eliminate all console output by default, ensuring the equivalent information is trivial to find in the logging. Critical in flight errors and resets could still make sense if used sparingly, but even there we'll want to make sure it's again captured by logging and perhaps even handled higher level (ekf2_main) to produce a mavlink critical message rather than console noise.

FYI @priseborough @bresch

@dagar dagar self-assigned this Sep 21, 2020
@dagar
Copy link
Member Author

dagar commented Sep 28, 2020

We also need to be careful with messages that have the potential to flood the console.

ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset
ERROR [ecl/EKF] airspeed badly conditioned - wind covariance reset

@priseborough
Copy link
Collaborator

This has been reduced, but there is scope for further improvement using data in flags. @dagar I'll keep this open for the time being.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants