Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

EKF: add fault status bit for clipping #917

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

dagar
Copy link
Member

@dagar dagar commented Oct 21, 2020

Does this make sense as a fault status bit? We don't necessarily have all the input data logged at full rate so I wanted to capture this somewhere within ecl/EKF status.

@dagar
Copy link
Member Author

dagar commented Oct 21, 2020

Relevant for multi-ekf, where we could switch the primary estimator immediately on clipping rather than waiting for the effects to accumulate in the comparison metrics (eg PX4/PX4-Autopilot#14650 (comment)).

@bresch
Copy link
Member

bresch commented Oct 26, 2020

Sounds like a good idea. Since you're already changing the status flags, can you also add _bad_vert_accel_detected in it? https://github.com/PX4/ecl/blob/f666ebb99552eed796e82a20bb60e813d45eee03/EKF/control.cpp#L902

@dagar
Copy link
Member Author

dagar commented Oct 26, 2020

Yes I'll add that as well.

We're already capturing _bad_vert_accel_detected as ekf_solution_status.accel_error, but that entire message seems to only exist for being passed through to Mavlink.

https://github.com/PX4/ecl/blob/dd3ffc419238bfc7d9b7e3be92a178c2cf7756f1/EKF/common.h#L495

http://mavlink.io/en/messages/common.html#ESTIMATOR_STATUS

Screenshot from 2020-10-26 10-25-14

We should really give this an overall review at some point, including killing off most of the console messages (#909).

@dagar dagar force-pushed the pr-ekf_fault_flags_clipping branch from c53b5ab to 4faf864 Compare October 26, 2020 14:31
@dagar
Copy link
Member Author

dagar commented Oct 26, 2020

Added bad_acc_vert to fault status.

@dagar dagar force-pushed the pr-ekf_fault_flags_clipping branch from 4faf864 to 6738a5a Compare October 26, 2020 14:34
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bresch bresch merged commit 6e99ebd into master Oct 26, 2020
@bresch bresch deleted the pr-ekf_fault_flags_clipping branch October 26, 2020 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants