Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers base/nuttx use PX4 setup script #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dagar
Copy link
Member

@dagar dagar commented Jun 23, 2020

No description provided.

@TSC21
Copy link
Member

TSC21 commented Jun 23, 2020

So are we reverting back to GCC 7?

@dagar dagar force-pushed the pr-install_from_px4 branch from 3773008 to 99330d4 Compare June 23, 2020 17:02
@dagar
Copy link
Member Author

dagar commented Jun 23, 2020

So are we reverting back to GCC 7?

No, we're respecting PX4/Firmware master. That's what developers can use at first setup or jumping between branches, what documentation can reference, and now what the actual build/dev environments respect.

The dependency changes the upgrade scenario (arguably a bit more awkward), but I think it's worth it to keep everything coordinated with PX4/Firmware dictating the sanctioned/recommended versions.

To upgrade you try the new toolchain locally (make check_nuttx) and work through any new warnings or issues. Then once reasonably sure we update PX4/Firmware's setup scripts (Tools/setup), propagate through docker, and finally bump the tags.

@TSC21
Copy link
Member

TSC21 commented Jun 23, 2020

So are we reverting back to GCC 7?

No, we're respecting PX4/Firmware master. That's what developers can use at first setup or jumping between branches, what documentation can reference, and now what the actual build/dev environments respect.

The dependency changes the upgrade scenario (arguably a bit more awkward), but I think it's worth it to keep everything coordinated with PX4/Firmware dictating the sanctioned/recommended versions.

To upgrade you try the new toolchain locally (make check_nuttx) and work through any new warnings or issues. Then once reasonably sure we update PX4/Firmware's setup scripts (Tools/setup), propagate through docker, and finally bump the tags.

I got that but I feel it's relevant to invest some time on trying to bring GCC 9 support already. I already spent some time around it and got stuck: PX4/PX4-Autopilot#14691. I think it could be valuable if you could help unblock this. Thanks

@dagar
Copy link
Member Author

dagar commented Jun 23, 2020

I got that but I feel it's relevant to invest some time on trying to bring GCC 9 support already. I already spent some time around it and got stuck: PX4/PX4-Autopilot#14691. I think it could be valuable if you could help unblock this. Thanks

There are a small number of v1.11 blocking issues https://github.com/PX4/Firmware/projects/17. As soon as those are out of the way we can bump GCC (now 9-2020-q2-update May 29, 2020).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants