Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod incompatibility: allow filtering of mods #27

Open
AstraLuma opened this issue Oct 15, 2022 · 3 comments
Open

Mod incompatibility: allow filtering of mods #27

AstraLuma opened this issue Oct 15, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@AstraLuma
Copy link

AstraLuma commented Oct 15, 2022

Not sure what can be done about this, but imma drop it here:

It looks like Pause instead of catching up is incompatible with the mapshot CLI.

It causes the process to just stop.

@Palats
Copy link
Owner

Palats commented Oct 17, 2022

Factorio mods are really tied to the sync'ed loop of Factorio - and thus do nothing when in pause as it would risk desync'ing the game. That includes running screenshotting and/or setting out of pause from the script (Rseding91 do confirms).

Given that the CLI do fiddle with a few things, there might be something in that direction, however:

  • Factorio does not seem to have flags to ignore pause (except something for benchmarking, unlikely to be relevant).
  • I imagine pause state is kept in the savegame file, and it is opaque in practice (and Factorio dev do not want to document it / open it, which is understandble).

So, long story short, I don't think there is anything doable here, so, closing unfortunately. (Obv. if you have a specific idea on how to avoid this problem, I'm all ears).

@Palats Palats closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2022
@AstraLuma
Copy link
Author

The pause state doesn't seem to be saved (at least in this case), and simply removing the mod seems to clear the problem up.

Given that the mapshot cli already copies the mod directory, putting a filter on that process seems relatively easy?

In the short term, I'll just add a script to my pipeline to remove it.

@Palats
Copy link
Owner

Palats commented Oct 23, 2022

Ah, thanks for the clarification - indeed, adding a way to filter out mods on the CLI would be straightforward and potentially useful.

@Palats Palats reopened this Oct 23, 2022
@Palats Palats changed the title Mod incompatibility: Pause Instead of Catching Up Mod incompatibility: allow filtering of mods Oct 23, 2022
@Palats Palats added the enhancement New feature or request label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants