Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Filter on the organizations screen  #1189

Closed
Hasnain01-hub opened this issue Dec 13, 2023 · 12 comments
Closed

Remove Filter on the organizations screen  #1189

Hasnain01-hub opened this issue Dec 13, 2023 · 12 comments
Assignees

Comments

@Hasnain01-hub
Copy link
Contributor

Hasnain01-hub commented Dec 13, 2023

Describe the bug
Remove filtering in the organization screen, the aim is to remove the filter code.

To Reproduce
Steps to reproduce the behavior:

  1. login into the talawa admin dashboard
  2. go to the orglist
  3. navigate the filter button
  4. see the issue

Screenshots
Screenshot 2023-12-13 at 12 04 40 PM

Additional details
NA

@Hasnain01-hub Hasnain01-hub added the bug Something isn't working label Dec 13, 2023
@Hasnain01-hub
Copy link
Contributor Author

@palisadoes can you assign this issue to me?

Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@noman2002
Copy link
Member

noman2002 commented Dec 13, 2023

@rishav-jha-mech @aashimawadhwa Is this a valid issue ??

If yes, please suggest the parameters for filtering.
@palisadoes Your thoughts on this.

@Devesh326
Copy link
Contributor

Hi @palisadoes
I just found this repository and would love to contribute! Can you elaborate bit more regarding this issue.

@noman2002
Copy link
Member

@Devesh326 We are assigning on first come first serve basis. This will be assigned to @Hasnain01-hub . You can take other open issues. Thanks

@noman2002 noman2002 added feature request and removed bug Something isn't working labels Dec 13, 2023
@Hasnain01-hub
Copy link
Contributor Author

Hasnain01-hub commented Dec 17, 2023

Hello @palisadoes @rishav-jha-mech @aashimawadhwa @noman2002, I have implemented the filter option in Orglist, but I have not got the feature parameters yet. So based on location (filter parameter is dynamic) I tried filtering. Also, I have implemented all the logic part on the client side, as it is more complex, and managing the state would be tougher so is it okay?
Result:

Screen.Recording.2023-12-16.at.11.55.15.PM.mov

@palisadoes
Copy link
Contributor

We are currently evaluating our product road map and decided that this feature needs to be removed as we have greater priorities at this time.

  1. Please convert this to a feature removal issue
  2. Make sure that the test code coverage is maintained
  3. Ensure that no other features are affected

Thanks

@palisadoes
Copy link
Contributor

@Hasnain01-hub This issue either needs to be:

  1. closed with a new issue created to remove the feature which we can then assign to you, or
  2. converted to an issue to remove the feature

@Hasnain01-hub
Copy link
Contributor Author

Hasnain01-hub commented Dec 21, 2023

@palisadoes Yes, convert to an issue to remove the feature, Additionally, could you confirm whether the filter implementation meets the condition, in the previously uploaded video, or if it requires additional parameters?

@palisadoes
Copy link
Contributor

  1. We don't want the filter at all. Please remove it from the screen and any related code behind the scenes that may have been used to implement it.
  2. This is an unwanted feature, as explained before

@Hasnain01-hub Hasnain01-hub changed the title Implement Filter on the organizations screen  Remove Filter on the organizations screen  Dec 23, 2023
@Hasnain01-hub
Copy link
Contributor Author

Hasnain01-hub commented Dec 23, 2023

@palisadoes Sir I have removed the filter Button from Orglist screen and the related code, Please verify it and should I open the pull request for it?
Screenshot:
Screenshot 2023-12-23 at 12 49 19 PM

@palisadoes
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants