-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figma: Events Page Violates The Figma Style Guide #3180
Comments
@palisadoes may I work on this issue? I have already worked with fixing some UI bugs for this page |
Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too. |
@palisadoes I want to take this up. |
@palisadoes I have almost resolved style related issue. Do I need to write test, if yes, then what type of? |
I want to work on this issue, please assign it to me |
I am working on it @Shahmaz0 |
@palisadoes progress till now, sorry i have taken a lot of time to solve this, due to some personal reason, but will raise the PR today or at max by tomorrow. Screen-Recording.mp4 |
We created an this issue to do basic changes to the CSS colors for consistency The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly. We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read. When this is done we'll need your assistance to merge the screens into the If your screens have not been affected, then you should use the new methodology to refactor them. This is an extraordinary circumstance. I hope you will appreciate the decision. |
Please proceed. The changes mentioned previously are mostly in components |
Post a video of your work in the PR
This will require someone with significant prior PRs in the repo
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Expected behavior
src/style/app.module.css
Other
Actual behavior
Screenshots
If applicable, add screenshots to help explain your problem.
Additional details
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: