Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma: Events Detail Popup Violates The Figma Style Guide #3181

Closed
palisadoes opened this issue Jan 6, 2025 · 7 comments
Closed

Figma: Events Detail Popup Violates The Figma Style Guide #3181

palisadoes opened this issue Jan 6, 2025 · 7 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

Post a video of your work in the PR

Describe the bug

  1. Events Page Violates The Figma Style Guide

To Reproduce
Steps to reproduce the behavior:

  1. Style Related
    1. Login to the app
    2. Select an organization
    3. Select Events
    4. Click on event
    5. The figma guide is not followed fully
  2. Functionality
    1. The blocked user functionality doesn't work (MAKE THIS A SEPARATE PR)

Expected behavior

  1. The screens shown must conform to Figma
  2. This must apply to the following were relevant:
    1. Users
    2. Admins
    3. SuperAdmins
  3. Tests must be written to ensure this does not happen again
  4. The CSS must be consolidated into this file using variables wherever possible
    1. src/style/app.module.css

Other

  1. We are migrating away from the green theme as part of our support for color blind users.
  2. Take cues from other similar elements in this file and the PR mentioned in the issue.
    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  3. Use a variable instead. There are appropriate blue/grey colors that have been used in other screens

Actual behavior

  • See screenshots

Screenshots

If applicable, add screenshots to help explain your problem.

  1. Screen
    image

Additional details

  1. Background color guide - Use these instead of those that may be different in sample pages below. Our Figma design is not consistent
    image
  2. Figma - Use as a guide
    image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Jan 6, 2025
@github-actions github-actions bot added ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 6, 2025
@raggettii
Copy link
Contributor

Please assign this to me @palisadoes

@raggettii raggettii removed their assignment Jan 10, 2025
@rshaw07
Copy link

rshaw07 commented Jan 10, 2025

@palisadoes can i work on this issue

@Shahmaz0
Copy link

I want to work on this issue, please assign it to me

@palisadoes
Copy link
Contributor Author

We created an this issue to do basic changes to the CSS colors for consistency

The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly.

We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read.

When this is done we'll need your assistance to merge the screens into the develop branch with this issue.

If your screens have not been affected, then you should use the new methodology to refactor them.

This is an extraordinary circumstance. I hope you will appreciate the decision.

@palisadoes
Copy link
Contributor Author

Please proceed. The changes mentioned previously are mostly in components

@palisadoes
Copy link
Contributor Author

@rshaw07 Are you still working on this?

@palisadoes
Copy link
Contributor Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Done
Development

No branches or pull requests

4 participants