Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Noticeable Difference Between H1, H2, H3, H4, H5, H6 CSS #937

Closed
palisadoes opened this issue Jan 12, 2025 · 9 comments · Fixed by #956
Closed

No Noticeable Difference Between H1, H2, H3, H4, H5, H6 CSS #937

palisadoes opened this issue Jan 12, 2025 · 9 comments · Fixed by #956
Assignees
Labels
good first issue Good for newcomers

Comments

@palisadoes
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  1. There is no Noticeable Difference Between H1, H2, H3, H4, H5, H6 CSS headings
  2. This makes it difficult to differentiate sections

Describe the solution you'd like

Create attractive discernible headings that are in keeping with the style of repository for:

  1. Light mode
  2. Dark mode

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • N/A

Additional context

image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added good first issue Good for newcomers and removed unapproved labels Jan 12, 2025
@Abdul-Moiz31
Copy link

@palisadoes Assigned this to me Please

@Abdul-Moiz31
Copy link

My Proposed Solution::

Adjust font sizes, weights, and spacing for each heading level to make them visually distinct.

  • H1: Large and bold (e.g., 2.5rem, bold).
  • H2: Slightly smaller but still prominent (e.g., 2rem, bold).
  • Gradually decrease size and weight for H3-H6.

Visual Enhancements:

  • For light mode, use darker shades (e.g., black, navy).
  • For dark mode, use lighter colors (e.g., white, light gray) with accessible contrast ratios.

Implementation:

  • I’ll ensure the styles are responsive and test them across different devices and screen sizes.
  • Use CSS variables to simplify light/dark mode toggling and ensure maintainability.

I’d love to contribute by implementing these changes. Please assign this issue to me if you think this approach works!
@palisadoes

@palisadoes
Copy link
Contributor Author

Please use a color palette generator like this:

Update your proposal accordingly

@Pawan8538
Copy link

ISSUE:

The problem arises in H1 heading only, every other heading is well structured.

MY PROPOSAL:

  • Removing the assigned size to h1 and giving it the appropriate size.

IMPROVEMENTS: (Changing background colors)

for dark mode

  • Side Navbar and Navbar (#121212 (Very Dark Gray))
  • for Body (#212121 (Dark Charcoal))

for light mode

  • Side Navbar and Navbar (#f3f4f6 )
  • for Body (#F8F8F8)

OUTPUT

Screenshot 2025-01-12 135357
Screenshot 2025-01-12 134350

@palisadoes if you want any further changes please comment and assign this issue to me.

@hars-21
Copy link
Contributor

hars-21 commented Jan 12, 2025

Issue:

There is issue in different heading sizes mainly H1.

Proposal:

  1. Improve Heading sizes
  2. Improve colours for headings
  3. Change navy blue colour to grey in dark mode for coded text

image
image
image

  1. Addition of vertical lines like this:
    image

For reference: I have taken same color palette from developer docs. Please let me know if any further changes are needed.

@palisadoes
Copy link
Contributor Author

I'm assigning this to @hars-21. The suggested font in the image is much better.

Consider using underlines, and slightly different colors like GitHub

GitHub H1 example

GitHub H2 example

GitHub H3 example

GitHub H4 example

GitHub H5 example
GitHub H6 example

@hars-21
Copy link
Contributor

hars-21 commented Jan 14, 2025

Hello Sir! As I was working on this issue, I noticed some bugs or areas of improvements in talawa docs.

  1. There is issue when i hover on one card, all other are also disturbed. And it creates a minor shake.
  2. There is lot of gap between sections. And it can lead to bad user experience.
Screencast.from.2025-01-14.22-51-32.webm
  1. In my opinion, we can make this heading inside the box below.

image

So, sir I would like to ask that should I solve these minor issues with this only and create a single PR for the whole. Or should I open a new issue and deal with it separately.

@palisadoes
Copy link
Contributor Author

  1. All in one PR.
  2. Right justify all text except in the three cards in the second row
  3. The left drawer in the /docs needs fixing. The spacing and the indentations could be smaller. The v3 and v2 documentation sites here were the original basis of the design.

@hars-21
Copy link
Contributor

hars-21 commented Jan 15, 2025

Ok sir, I will make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants