Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomProgressDialog Widget Not Handling Internet Connectivity Properly #2735

Open
may-tas opened this issue Feb 7, 2025 · 1 comment
Open
Assignees
Labels
bug Something isn't working documentation Update documentation unapproved Unapproved, needs to be triaged

Comments

@may-tas
Copy link
Contributor

may-tas commented Feb 7, 2025

Describe the bug

  • The CustomProgressDialog widget does not correctly handle internet connectivity. It always displays the CupertinoActivityIndicator, even when there is no internet connection. According to the documentation, it should show a "No Internet" image and text when offline.

To Reproduce
Steps to reproduce the behavior:

1.Run the app with an active internet connection.
2.After logging in to the app, try creating an event normally.
3.Now turn off the internet connection and try creating an event.
3.Notice that the loading indicator still appears instead of the expected "No Internet" UI.
4.Compare it with the intended behavior in the documentation.

Expected behavior
When there is no internet connection, the CustomProgressDialog widget should display:

  • A "No Internet" image
  • A message saying "No Internet"

Actual behavior

  • The widget always shows the CupertinoActivityIndicator, regardless of connectivity status.

Screenshots
Screenshot 1: Current implementation

Image

Screenshot 2: Expected implementation as per documentation

Image

Additional details

  • We just have to add the correct implementation according to the documentation using the connectivity check (model.connectivityPresent).

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@may-tas may-tas added the bug Something isn't working label Feb 7, 2025
@github-actions github-actions bot added documentation Update documentation unapproved Unapproved, needs to be triaged labels Feb 7, 2025
@may-tas
Copy link
Contributor Author

may-tas commented Feb 7, 2025

It's a minor issue, but still worth addressing. Please assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Update documentation unapproved Unapproved, needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant