New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please can we have resource counts for ELBs and EKS clusters? #48

Open

dedayosam opened this issue Feb 1, 2023 · 2 comments

Labels

dedayosam commented Feb 1, 2023

Please can we have resource counts for ELBs and EKS clusters?

I see code for listing the EKS clusters in the resource-count-aws.sh script but no flag for it. Same for the ELBs as well.

Thank you.

The text was updated successfully, but these errors were encountered:

dedayosam added the enhancement label

welcome-to-palo-alto-networks bot commented Feb 1, 2023

🎉 Thanks for opening your first issue here! Welcome to the community!

Contributor

tkishel commented Feb 1, 2023

If cwp is specified as a parameter:

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L56

We do count EKS clusters:

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L528

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L259

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L498

And we always count ELBs:

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L259

You can verify this by adding -x to line 1 and running.

https://superuser.com/questions/1537905/what-does-x-mean-in-this-line-bin-sh-x#:~:text=What%20x%20mean%20in%20the,entire%20script%20in%20debug%20mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment