From 5fbf3d9b14757cec67b279f95de17434a8e082cb Mon Sep 17 00:00:00 2001 From: Eva Lott Date: Tue, 24 Sep 2024 13:41:41 +0100 Subject: [PATCH] removed `min_units` from `TimeFieldInfo` (#96) --- src/pandablocks/commands.py | 5 ++--- src/pandablocks/responses.py | 1 - tests/test_pandablocks.py | 2 -- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/pandablocks/commands.py b/src/pandablocks/commands.py index b94a0f6a..7a5d32e6 100644 --- a/src/pandablocks/commands.py +++ b/src/pandablocks/commands.py @@ -510,13 +510,12 @@ def _enum( def _time( self, field_name: str, field_type: str, field_subtype: Optional[str] ) -> _FieldGeneratorType: - desc, units, min = yield from _execute_commands( + desc, units = yield from _execute_commands( self._get_desc(field_name), GetMultiline(f"*ENUMS.{self.block}.{field_name}.UNITS"), - GetLine(f"{self.block}1.{field_name}.MIN"), ) - field_info = TimeFieldInfo(field_type, field_subtype, desc, units, float(min)) + field_info = TimeFieldInfo(field_type, field_subtype, desc, units) return field_name, field_info diff --git a/src/pandablocks/responses.py b/src/pandablocks/responses.py index 01d2e558..e4a2d220 100644 --- a/src/pandablocks/responses.py +++ b/src/pandablocks/responses.py @@ -90,7 +90,6 @@ class TimeFieldInfo(FieldInfo): """Extended `FieldInfo` for fields with type "time""" units_labels: list[str] - min_val: float @dataclass diff --git a/tests/test_pandablocks.py b/tests/test_pandablocks.py index a909b8a8..9d8c0440 100644 --- a/tests/test_pandablocks.py +++ b/tests/test_pandablocks.py @@ -752,14 +752,12 @@ def idfn(val): None, [ ("*ENUMS.TEST.TEST_FIELD.UNITS?", "!VAL1\n!VAL2\n."), - ("TEST1.TEST_FIELD.MIN?", "OK =5e-8"), ("*DESC.TEST.TEST_FIELD?", "OK =Test Description"), ], TimeFieldInfo( "time", None, units_labels=["VAL1", "VAL2"], - min_val=5e-8, description="Test Description", ), ),