Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Trees are detected as falling trees instead of blacklisted #79

Open
WenXin20 opened this issue Jun 30, 2024 · 6 comments
Open

Comments

@WenXin20
Copy link

Minecraft v1.20.1
Dynamic Trees v1.3.0-Beta 7
Panda's Falling Trees v0.12.3

Panda's Falling Trees sometimes take over Dynamic Trees falling animation, which is apparent when it shows disconnected logs. This seems to happen since the blocks dynamictrees:branches are also tagged with minecraft:logs.
If a blacklist_tags option was added, the tag dynamictrees:branches could be added to prevent this.

2024-06-30_13 03 41

@WenXin20 WenXin20 changed the title Dynamic Trees are detected Dynamic Trees are detected as falling trees instead of blacklisted Jun 30, 2024
@Chip88898
Copy link

Does the blacklist tag work as a solution or is that just a suggestion for how it could be fixed? Asking because I’m having the same issue on a server where I wanted to use Pandas as a workaround to get the falling effect on trees from Biomes O Plenty on 1.20.1 since that compat mod is not up to date yet while still having normal dynamic trees for the vanilla ones.

@WenXin20
Copy link
Author

WenXin20 commented Jul 2, 2024

Does the blacklist tag work as a solution or is that just a suggestion for how it could be fixed? Asking because I’m having the same issue on a server where I wanted to use Pandas as a workaround to get the falling effect on trees from Biomes O Plenty on 1.20.1 since that compat mod is not up to date yet while still having normal dynamic trees for the vanilla ones.

The blacklist tag is just a suggestion. By the way, DT BOP is on 1.20.1 now.

@Chip88898
Copy link

Does the blacklist tag work as a solution or is that just a suggestion for how it could be fixed? Asking because I’m having the same issue on a server where I wanted to use Pandas as a workaround to get the falling effect on trees from Biomes O Plenty on 1.20.1 since that compat mod is not up to date yet while still having normal dynamic trees for the vanilla ones.

The blacklist tag is just a suggestion. By the way, DT BOP is on 1.20.1 now.

Thanks for the response! Didn’t know it had updated recently.

@MrKashew
Copy link

@PandaDap2006 bump for this compat - any thoughts on this bug?

@ThePandaOliver
Copy link
Member

Thanks for bumping.
It will not be a priority right now as I have other things I find more important, but that does not mean I won't implement it.
I'll take a look at it when I have finished some of my other plans.

@MrKashew
Copy link

the tag dynamictrees:branches could be added to prevent this.

is "*" identifier possible via config for blacklist (blocks) to do e.g.

"blacklist": [
  "dynamictrees:*"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants