Lots of fixes #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their own user-agent. Also made user-agent usage consistent troughout http-requests.
…now from reddit which scopes the access token is valid for. Otherwise your application would have to trust the client code not being manipulated into asking for different scopes.
… OAuth.registerService. refreshToken is now added the same way as accessToken
removed deprecated meteor.http.post and used HTTP.call
|
I wrote my changes years ago and don't remember if there are any breaking changes. I quickly skimmed trough the changes and the default scope changed from "read" to "identity". This will make applications relying on the default scope being "read" break when trying to use that scope. Might be more changes like this hidden in there that I missed. Just something to be vary of when setting the version, and writing patch notes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a number of fixes already implemented in the fork by @SimplyLinn.
My own contribution is to include some missing dependencies, Random and Underscore. This will resolve issue #6 on the meteor-accounts-reddit repo.